boards/nucleo144-f303: initial support#6625
Merged
kYc0o merged 3 commits intoRIOT-OS:masterfrom Apr 5, 2017
Merged
Conversation
aabadie
added
Platform: ARM
Contributor
|
?? and why? |
Contributor
Author
|
oups, I deleted the wrong branch... |
kYc0o
requested changes
Mar 15, 2017
Contributor
kYc0o
left a comment
kYc0o
left a comment
There was a problem hiding this comment.
Looks OK, just a minor comment. Needs testing though.
| FEATURES_PROVIDED += periph_spi | ||
| FEATURES_PROVIDED += periph_timer | ||
| FEATURES_PROVIDED += periph_uart | ||
| FEATURES_PROVIDED += periph_pwm |
Contributor
There was a problem hiding this comment.
Remember the alphabetical order.
Contributor
Author
|
@kYc0o : done and rebased |
aabadie
force-pushed
the
nucleo144_f303
branch
3 times, most recently
from
2b865b0 to
03a13ee
Compare
aabadie
added
the
CI: ready for build
aabadie
commented
Mar 24, 2017
| } | ||
| }; | ||
|
|
||
| #define TIMER_0_ISR isr_tim5 |
Contributor
Author
There was a problem hiding this comment.
the error is here, it should be isr_tim2
Contributor
Author
|
@astralien3000, I forced push an update, It should be ok now. @kYc0o can you make a quick code review again ? |
Member
|
PWM 0 (TIM1) is not working |
Member
|
Everything seems ok (default, uart, pwm, timer) |
aabadie
added
CI: ready for build
Contributor
Author
|
@kYc0o , can you ACK ? |
kaspar030
added
CI: ready for build
Contributor
Author
|
ping @kYc0o |
Contributor
Author
|
ping @kYc0o, for an ACK please :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another port of Nucleo board. This one is for the Nucleo-F303ZE.
Let's wait for the CI to fix the usual memory overflow issues.