Skip to content

boards/nucleo-f302: initial support#6615

Merged
kYc0o merged 5 commits intoRIOT-OS:masterfrom
aabadie:nucleo_f302
Mar 16, 2017
Merged

boards/nucleo-f302: initial support#6615
kYc0o merged 5 commits intoRIOT-OS:masterfrom
aabadie:nucleo_f302

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Feb 15, 2017

This PR adds support for another Nucleo board : Nucleo-F302. It was the last Nucleo 64 FXXX without support in RIOT (and there are still opened PRs for some others).

Thanks to @kYc0o for the ST Link upgrade tip : this did the job :)

Configured:

  • One Timer,
  • 3 UARTs,
  • 1 PWM
  • 1 SPIs

@aabadie aabadie added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Feb 15, 2017
@aabadie aabadie added this to the Release 2017.04 milestone Feb 15, 2017
@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Feb 16, 2017

@aabadie Can you maybe update the wiki of nucleo boards with this fix?

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Feb 16, 2017

Can you maybe update the wiki of nucleo boards with this fix?

Done: https://github.com/RIOT-OS/RIOT/wiki/Board%3A-Nucleo-F302

@aabadie aabadie force-pushed the nucleo_f302 branch 3 times, most recently from 783f565 to df3b044 Compare February 24, 2017 22:37
@aabadie aabadie force-pushed the nucleo_f302 branch 2 times, most recently from 788709c to ef0e96f Compare March 1, 2017 12:03
@aabadie aabadie force-pushed the nucleo_f302 branch 2 times, most recently from 3459e8d to bbac99a Compare March 8, 2017 21:09
@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Mar 14, 2017

rebased

/* bus clocks for simplified peripheral initialization, UPDATE MANUALLY! */
#define CLOCK_AHB (CLOCK_CORECLOCK / 1)
#define CLOCK_APB2 (CLOCK_CORECLOCK / 1)
#define CLOCK_APB1 (CLOCK_CORECLOCK / 2)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What it means UPDATE MANUALLY?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the datasheet, you have to set the maximum speed allowed for each BUS relatively to the clock speed : for this CPU, AHB and ABP uses the same clock speed (72MHz) and APB1 half the clock.

* @name DAC configuration
* @{
*/
#define DAC_NUMOF (0)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No DAC ok, but ADC? In other implementations this is marked as 0 too...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update that

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I missed this one

.rx_pin = GPIO_PIN(PORT_B, 11),
.tx_pin = GPIO_PIN(PORT_B, 10),
.rx_pin = GPIO_PIN(PORT_C, 11),
.tx_pin = GPIO_PIN(PORT_C, 10),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks strange, it's the same file as above but modify different lines, can you check?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I misread, it's changing something on nucleo-f303, so I think this should be in a separated PR.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, my bad, will revert

Copy link
Copy Markdown
Contributor

@kYc0o kYc0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments but looks OK. Just mind to rebase to master to include #6740 .

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Mar 15, 2017

comments addressed and branch rebased

@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 16, 2017
@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Mar 16, 2017

ping @kYc0o

@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Mar 16, 2017

ACK and go.

@kYc0o kYc0o merged commit f839e73 into RIOT-OS:master Mar 16, 2017
@aabadie aabadie deleted the nucleo_f302 branch February 26, 2018 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants