boards/nucleo-f302: initial support#6615
Conversation
|
@aabadie Can you maybe update the wiki of nucleo boards with this fix? |
|
783f565 to
df3b044
Compare
788709c to
ef0e96f
Compare
3459e8d to
bbac99a
Compare
|
rebased |
| /* bus clocks for simplified peripheral initialization, UPDATE MANUALLY! */ | ||
| #define CLOCK_AHB (CLOCK_CORECLOCK / 1) | ||
| #define CLOCK_APB2 (CLOCK_CORECLOCK / 1) | ||
| #define CLOCK_APB1 (CLOCK_CORECLOCK / 2) |
There was a problem hiding this comment.
What it means UPDATE MANUALLY?
There was a problem hiding this comment.
According to the datasheet, you have to set the maximum speed allowed for each BUS relatively to the clock speed : for this CPU, AHB and ABP uses the same clock speed (72MHz) and APB1 half the clock.
| * @name DAC configuration | ||
| * @{ | ||
| */ | ||
| #define DAC_NUMOF (0) |
There was a problem hiding this comment.
No DAC ok, but ADC? In other implementations this is marked as 0 too...
There was a problem hiding this comment.
sorry I missed this one
| .rx_pin = GPIO_PIN(PORT_B, 11), | ||
| .tx_pin = GPIO_PIN(PORT_B, 10), | ||
| .rx_pin = GPIO_PIN(PORT_C, 11), | ||
| .tx_pin = GPIO_PIN(PORT_C, 10), |
There was a problem hiding this comment.
This change looks strange, it's the same file as above but modify different lines, can you check?
There was a problem hiding this comment.
OK I misread, it's changing something on nucleo-f303, so I think this should be in a separated PR.
There was a problem hiding this comment.
good catch, my bad, will revert
|
comments addressed and branch rebased |
|
ping @kYc0o |
|
ACK and go. |
This PR adds support for another Nucleo board : Nucleo-F302. It was the last Nucleo 64 FXXX without support in RIOT (and there are still opened PRs for some others).
Thanks to @kYc0o for the ST Link upgrade tip : this did the job :)
Configured: