Closed
Conversation
d0b3fa7 to
8324589
Compare
Member
Author
|
@gebart now LLVM fails when compiling you see this error too?` |
Member
|
Well it is a tautological comparison, so it should be fixed (LOG_INFO ==
LOG_INFO)
…On Feb 15, 2017 1:42 PM, "Sebastian Meiling" ***@***.***> wrote:
@gebart <https://github.com/gebart> now LLVM fails when compiling
tests/unittests/ with:
kernel_init.c:58:18: error: self-comparison always evaluates to true [-Werror,-Wtautological-compare]
if (LOG_INFO <= LOG_INFO) printf("main(): This is RIOT! (Version: " "buildtest" ")\n");
^
1 error generated.
you see this error too?`
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6600 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AATYQkIBtnr4aR8bwgmpr4gKGUH76vA4ks5rcvKPgaJpZM4MAhV9>
.
|
Member
|
But no, I did not see the same error.
On Feb 15, 2017 1:59 PM, "Joakim Nohlgård" <[email protected]>
wrote:
… Well it is a tautological comparison, so it should be fixed (LOG_INFO ==
LOG_INFO)
On Feb 15, 2017 1:42 PM, "Sebastian Meiling" ***@***.***>
wrote:
> @gebart <https://github.com/gebart> now LLVM fails when compiling
> tests/unittests/ with:
>
> kernel_init.c:58:18: error: self-comparison always evaluates to true [-Werror,-Wtautological-compare]
> if (LOG_INFO <= LOG_INFO) printf("main(): This is RIOT! (Version: " "buildtest" ")\n");
> ^
> 1 error generated.
>
> you see this error too?`
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#6600 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AATYQkIBtnr4aR8bwgmpr4gKGUH76vA4ks5rcvKPgaJpZM4MAhV9>
> .
>
|
Member
Author
|
@gebart Jenkins uses |
8324589 to
9a371ba
Compare
Member
Author
086c537 to
2ad5a45
Compare
Member
Author
|
|
fce9928 to
ac9b21f
Compare
ac9b21f to
3d6a79f
Compare
Contributor
|
Can we try to get this merged before #6673 ? |
Member
Author
|
nope, there are more parts missing. |
c522e5d to
c8c82aa
Compare
c8c82aa to
9875f06
Compare
Member
Author
|
separated commits into extra PR #6752 |
661ed34 to
fafbde0
Compare
- set no-keyword-macro
- set no-parentheses-equality
- set no-gnu-zero-variadic-macro-arguments
- set no-unused-function
80e1d72 to
fd29269
Compare
Member
Author
|
closing as memo, as we go for Murdock 2 instead Jenkins - at least for the time being |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR enables all tests on native using LLVM toolchain, it depends on
#6598#6609.