tests/driver_mq3: fix build upon avr 8 bits MCU#6581
Merged
PeterKietzmann merged 2 commits intoRIOT-OS:masterfrom Feb 16, 2017
Merged
tests/driver_mq3: fix build upon avr 8 bits MCU#6581PeterKietzmann merged 2 commits intoRIOT-OS:masterfrom
PeterKietzmann merged 2 commits intoRIOT-OS:masterfrom
Conversation
fix tests/driver_mq3/main.c:58:27: error: integer overflow in expression [-Werror=overflow]
xtimer_usleep(500 * 1000);
Closed
PeterKietzmann
added
Type: bug
Member
|
@mali please check Jenkins log |
Contributor
Author
|
strange... timex.h is included by xtimer.h, anyway, re use literal number instead. |
using define constants from timex.h breaks build for some boards.
Closed
PeterKietzmann
added
the
CI: ready for build
Member
|
should've been squashed before merge ... wasn't there a fine on such things 😜 |
Contributor
Author
|
I was thinking that too :-) |
Member
I guess there will be free beer tomorrow in Hamburg ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this test won't build with avr MCU like atmega328p because of
tests/driver_mq3/main.c:58:27: error: integer overflow in expression [-Werror=overflow]
xtimer_usleep(500 * 1000);
also use timex.h constant define.
see #6148