Skip to content

mulle: Use hardware CS for on-board LIS3DH#6572

Merged
haukepetersen merged 2 commits intoRIOT-OS:masterfrom
jnohlgard:pr/mulle-lis3dh-settings
Aug 24, 2017
Merged

mulle: Use hardware CS for on-board LIS3DH#6572
haukepetersen merged 2 commits intoRIOT-OS:masterfrom
jnohlgard:pr/mulle-lis3dh-settings

Conversation

@jnohlgard
Copy link
Copy Markdown
Member

This PR changes the board configuration to use hardware CS for the on-board LIS3DH accelerometer and changes the lis3dh driver to use SPI mode 3, which is what the LIS3DH data sheet specifies.

@jnohlgard jnohlgard added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: drivers Area: Device drivers labels Feb 7, 2017
@jnohlgard jnohlgard added this to the Release 2017.04 milestone Feb 7, 2017
@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Jun 20, 2017

I guess we missed this one because it seems to be mergeable. Anyone for an ACK ?

@jnohlgard jnohlgard assigned kYc0o and unassigned haukepetersen Aug 3, 2017
@jnohlgard jnohlgard added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 3, 2017
@jnohlgard
Copy link
Copy Markdown
Member Author

@kYc0o do you mind taking a look at this PR? It should be enough to see that the accelerometer works with SAUL in the default example.

Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected -> ACK

@haukepetersen
Copy link
Copy Markdown
Contributor

Also all green -> go

@haukepetersen haukepetersen merged commit 7ea1e9d into RIOT-OS:master Aug 24, 2017
@jnohlgard jnohlgard deleted the pr/mulle-lis3dh-settings branch August 25, 2017 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants