Skip to content

unittests: fix heatshrink compiler error on macOS#6440

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
smlng:pr/unittests/macos_fix
Jan 20, 2017
Merged

unittests: fix heatshrink compiler error on macOS#6440
miri64 merged 1 commit intoRIOT-OS:masterfrom
smlng:pr/unittests/macos_fix

Conversation

@smlng
Copy link
Copy Markdown
Member

@smlng smlng commented Jan 20, 2017 •
edited
Loading

required by #6341

@smlng smlng added OS: Mac OS X Host OS: This PR/issue concerns usage of RIOT with Mac OS X as a host system Area: tests Area: tests and testing framework labels Jan 20, 2017
@smlng smlng mentioned this pull request Jan 20, 2017
Closed
@miri64 miri64 added this to the Release 2017.01 milestone Jan 20, 2017
@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 20, 2017
kaspar030
kaspar030 approved these changes Jan 20, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK if CI agrees.

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Jan 20, 2017

for clarification, fixes following error reported by clang:

/RIOT/tests/unittests/tests-heatshrink/tests-heatshrink.c:51:58: error: incompatible pointer types passing
      'unsigned int *' to parameter of type 'size_t *' (aka 'unsigned long *') [-Werror,-Wincompatible-pointer-types]
            heatshrink_encoder_sink(&_encoder, inpos, n, &n_sunk);
                                                         ^~~~~~~

@miri64 miri64 merged commit aab4845 into RIOT-OS:master Jan 20, 2017
@smlng smlng deleted the pr/unittests/macos_fix branch May 31, 2017 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

Assignees

@kaspar030 kaspar030

Labels

Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR OS: Mac OS X Host OS: This PR/issue concerns usage of RIOT with Mac OS X as a host system

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smlng @kaspar030 @miri64