Skip to content

pkg: tinydtls: Upgrades (02c)#6430

Closed
rfuentess wants to merge 3 commits intoRIOT-OS:masterfrom
rfuentess:TinyDTLS-Upgrades02c
Closed

pkg: tinydtls: Upgrades (02c)#6430
rfuentess wants to merge 3 commits intoRIOT-OS:masterfrom
rfuentess:TinyDTLS-Upgrades02c

Conversation

@rfuentess
Copy link
Copy Markdown
Contributor

@rfuentess rfuentess commented Jan 19, 2017

Hi people!

I have been working on my TinyDTLS branch on the last days.

This PR brings 3 things:

  1. RIOT will uses my TinyDTLS master branch by default instead of a specific commit.
  2. The default example has a series of fixes and is saving a little more of memory now.
  3. The current configuration (only PSK mode and TinyDTLS' debug messages disabled) is more stable. Probably due to other PRs related to hardware performance.

I have been speaking with @kYc0o about what is next and for now is increasing the stability for ECC. But probably, that will be reflected only on my TinyDTLS fork. After that, I'll try again with sock.

This PR is free of the merge conflict of #6319

@rfuentess
pkg/tinydtls: master branch of remote fork is used. Dependencies are …
ab6c232 
…moved here

The remote fork of TinyDTLS is now used solely for RIOT instead of Linux and
Contiki. Also, all the dependencies that are static for TinyDTLs were moved
from the examples/dtls-echo/Makefile to pkg/tinydtls/Makefile.dep .
@rfuentess rfuentess mentioned this pull request Jan 19, 2017
Closed
@rfuentess
Copy link
Copy Markdown
Contributor Author

rfuentess commented Jan 19, 2017

Question, I just saw that the recently commit 59cc590 modified examples/dtls-echo/Makefile with 2 extras boards (nucleo32-f042 nucleo32-f303) to the black list. Sadly, They are being removed by this PR.

Do you want that I upload a third commit adding them back? Or I do the commit, and then squashed with the last one and then git -f push?

@OlegHahm OlegHahm added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking Area: pkg Area: External package ports labels Jan 19, 2017
@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Jan 20, 2017

Do you know why they were removed? It was a mistake?

@rfuentess
Copy link
Copy Markdown
Contributor Author

rfuentess commented Jan 20, 2017

A mistake from my part.

@kYc0o kYc0o added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 23, 2017
@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Jan 23, 2017

Something seems wrong with this PR... Can you try to rebase?

@rfuentess
examples/dtls-echo: Improvements over performance and readability.
3d68e91 
Main changes:
- README.md has references for -ack_req (Crucial for good performance)
- ECC is disabled by default.
- Main Makefile only concerns about the application, not the package (ab6c232)
- The idle time after sending packets is removed.
- DEBUG is used instead of puts or printf (Except with errors)
- Useless variables are removed.
- Comments were upgraded.
@rfuentess rfuentess force-pushed the TinyDTLS-Upgrades02c branch from 4db2ad3 to 3d68e91 Compare January 23, 2017 14:19
@rfuentess
Copy link
Copy Markdown
Contributor Author

rfuentess commented Jan 23, 2017

Squashing the fix for the override conflict seems to be the solution.

kaspar030
kaspar030 requested changes Jan 23, 2017
View reviewed changes
pkg/tinydtls/Makefile Outdated
PKG_URL=https://github.com/rfuentess/TinyDTLS.git
# PKG_VERSION=RIOT-OS
PKG_VERSION=d06ad84d3e8bd3e86f7557faee34b68d5f8c0129
PKG_VERSION=master
Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 Jan 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to actually use the HEAD of the master branch?

We use fixed commits or tags to ensure proper rebuilds.

Copy link
Copy Markdown
Contributor Author

@rfuentess rfuentess Jan 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My idea behind using the master branch instead of a specific commit was to be able to be working with the package TinyDTLS without requiring to do a PR to RIOT. As the TinyDTLS package can still be improved for RIOT. This is why there was an extra commented line for a testing branch.

However, if this is a very bad course of action for RIOT. Then, I'll modify it to original approach.

@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Jan 23, 2017

RIOT will uses my TinyDTLS master branch by default instead of a specific commit.

Please don't. Currently, every commit in RIOT compiles exactly the same codebase, including packages. Changing a package to use a random branch HEAD, this property is lost.

@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Jan 23, 2017

Please rename the PR. "pkg: tinydtls: "

@rfuentess rfuentess changed the title TinyDTLS upgrades02c pkg: tinydtls: Upgrades (02c) Jan 23, 2017
@rfuentess
Copy link
Copy Markdown
Contributor Author

rfuentess commented Jan 23, 2017

Changes done.

@rfuentess rfuentess mentioned this pull request May 19, 2017
Closed
@rfuentess rfuentess mentioned this pull request Jun 12, 2017
Closed
6 tasks
@rfuentess rfuentess closed this Jun 12, 2017
@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Jun 12, 2017

Can you explain a bit why this is closed? I read the reference on #7177 but I cannot see why such PR deprecates this one.

@rfuentess
Copy link
Copy Markdown
Contributor Author

rfuentess commented Jun 12, 2017

The commit for the pkg/tinydtls/Makefile was update, plus this commit requires that the user put variables in the application's Makefile that should be in pkg/tinydtls/Makefile.dep .

Also, the client and server for the dtls-echo were upgraded in the new PR for supporting CoAP spoofed messages which also impacted in the dtls-echo/Makefile. And, the dtls-echo version of the new PR has been tested successfully with PSK and RPK modes over the iotlab-m3 board.

@rfuentess rfuentess deleted the TinyDTLS-Upgrades02c branch June 28, 2018 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaspar030 kaspar030 kaspar030 requested changes

Assignees

@kYc0o kYc0o

Labels

Area: network Area: Networking Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rfuentess @kYc0o @kaspar030 @OlegHahm