Skip to content

boards/nucleo32-f042: change board name nucleo->nucleo32#6417

Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom
aabadie:nucleo32-f042
Jan 19, 2017
Merged

boards/nucleo32-f042: change board name nucleo->nucleo32#6417
aabadie merged 1 commit intoRIOT-OS:masterfrom
aabadie:nucleo32-f042

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Jan 18, 2017

This PR is a simple name change of nucleo-f042 to nucleo32-f042. I followed the convention:

  • nucleo32-xx: nucleo boards with 32 pins (nucleo32-f303)
  • nucleo-xx: nucleo boards with 64 pins (nucleo-f401, f103, f303, etc)
  • nucleo-144: nucleo boards with 144 pins (I have one or 2 of them)

The goal of this PR is just to be consistent with the choice made in #6377 and can be discussed of course.

@haukepetersen haukepetersen self-assigned this Jan 18, 2017
@haukepetersen haukepetersen added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Jan 18, 2017
@haukepetersen haukepetersen added this to the Release 2017.01 milestone Jan 18, 2017
haukepetersen
haukepetersen approved these changes Jan 18, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@haukepetersen
Copy link
Copy Markdown
Contributor

haukepetersen commented Jan 18, 2017

Additionally I wonder, if we can document the naming scheme you describe above somewhere, so that it will be clear for everyone interested in it? How about a generic Board: Nucleo page in the wiki?

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Jan 18, 2017

How about a generic Board: Nucleo page in the wiki?

Sounds good, the nucleo pages are quite the same in the wiki, factorizing them would be great.

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Jan 19, 2017

All green, merging !

@aabadie aabadie merged commit 0717129 into RIOT-OS:master Jan 19, 2017
@miri64 miri64 mentioned this pull request Feb 10, 2017
Merged
@aabadie aabadie mentioned this pull request Feb 28, 2017
Merged
@aabadie aabadie deleted the nucleo32-f042 branch March 6, 2017 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haukepetersen haukepetersen haukepetersen approved these changes

Assignees

@haukepetersen haukepetersen

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aabadie @haukepetersen