Skip to content

pkg/ccn-lite: add patch for compiler error#6352

Closed
smlng wants to merge 1 commit intoRIOT-OS:masterfrom
smlng:pr/pkg/ccn-lite/compile_error
Closed

pkg/ccn-lite: add patch for compiler error#6352
smlng wants to merge 1 commit intoRIOT-OS:masterfrom
smlng:pr/pkg/ccn-lite/compile_error

Conversation

@smlng
Copy link
Copy Markdown
Member

@smlng smlng commented Jan 13, 2017

fixes the following compile error on macOS with clang:

/RIOT/examples/ccn-lite-relay/bin/pkg/native/tlsf/src  -Wall -Werror -std=c99 -g -Wno-error=deprecated-declarations -c ccn-lite-riot.c
ccn-lite-riot.c:290:52: error: format specifies type 'int' but the argument has type 'long' [-Werror,-Wformat]
    DEBUGMSG(TRACE, "ccnl_ll_TX %d bytes to %s\n", buf ? buf->datalen : -1, ccnl_addr2ascii(dest));
                                ~~                 ^~~~~~~~~~~~~~~~~~~~~~~
                                %ld

@smlng smlng added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) OS: Mac OS X Host OS: This PR/issue concerns usage of RIOT with Mac OS X as a host system Area: pkg Area: External package ports labels Jan 13, 2017
@smlng smlng added this to the Release 2017.01 milestone Jan 13, 2017
@smlng
Copy link
Copy Markdown
Member Author

smlng commented Jan 13, 2017

required for #6341

@smlng smlng mentioned this pull request Jan 13, 2017
Closed
@smlng smlng force-pushed the pr/pkg/ccn-lite/compile_error branch from 608a1c6 to 2bfdba7 Compare January 13, 2017 20:43
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Jan 14, 2017 •
edited
Loading

This seems like something that could/should be patched upstream.

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Jan 14, 2017

@OlegHahm if possible, sure! However, I'd like to get this fixed fast, to enable macOS in Jenkins and have clean builds for starters.

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Jan 15, 2017

@cgundogan and I are maintainers of ccn-lite, too. Hence merging anything there shouldn't take longer than merging it here - and could save us more patch files.

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Jan 15, 2017

what about the other patch by @miri64?

So, I create a patch for ccn-lite; you ( @OlegHahm ) or @cgundogan merge and then another PR here to update the package. I'd like to get this and related PRs #6326, #6333, and #6351 for #6341 merged for the next release.

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Jan 15, 2017

@OlegHahm see PR 100,

@smlng smlng mentioned this pull request Jan 15, 2017
Closed
@smlng
Copy link
Copy Markdown
Member Author

smlng commented Jan 15, 2017

replaced by #6364 and ccn-lite PR 100

@smlng smlng closed this Jan 15, 2017
@smlng smlng deleted the pr/pkg/ccn-lite/compile_error branch January 15, 2017 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kYc0o kYc0o

Labels

Area: pkg Area: External package ports OS: Mac OS X Host OS: This PR/issue concerns usage of RIOT with Mac OS X as a host system Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smlng @OlegHahm @kYc0o