Skip to content

pkg/tinydtls: add compiler flags to Makefile.include#6351

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
smlng:pr/pkg/tinydtls_compile_errors
Jan 19, 2017
Merged

pkg/tinydtls: add compiler flags to Makefile.include#6351
miri64 merged 1 commit intoRIOT-OS:masterfrom
smlng:pr/pkg/tinydtls_compile_errors

Conversation

@smlng
Copy link
Copy Markdown
Member

@smlng smlng commented Jan 13, 2017

resolves two compile errors with tinydtls package on macOS:

/RIOT/examples/dtls-echo/bin/pkg/native/tinydtls/dtls.c:194:37: error: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Werror,-Wgnu-zero-variadic-macro-arguments]
   ? (Context)->h->which((Context), ##__VA_ARGS__)                      \
                                    ^

and

/RIOT/examples/dtls-echo/bin/pkg/native/tinydtls
dtls_debug.c:108:1: error: unused function 'dtls_strnlen' [-Werror,-Wunused-function]
dtls_strnlen(const char *s, size_t maxlen) {
^

@smlng smlng added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) OS: Mac OS X Host OS: This PR/issue concerns usage of RIOT with Mac OS X as a host system labels Jan 13, 2017
@smlng smlng added this to the Release 2017.01 milestone Jan 13, 2017
@smlng
Copy link
Copy Markdown
Member Author

smlng commented Jan 13, 2017

also required to make #6341 work

@smlng smlng mentioned this pull request Jan 13, 2017
Closed
@smlng smlng added the Area: pkg Area: External package ports label Jan 13, 2017
@smlng smlng mentioned this pull request Jan 15, 2017
Closed
@smlng smlng added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 18, 2017
@smlng
Copy link
Copy Markdown
Member Author

smlng commented Jan 18, 2017

@PeterKietzmann this should go into the release, only minor changes, but helps to fix compiler errors on macOS. But lets for Murdock to be happy ...

kYc0o
kYc0o approved these changes Jan 18, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@kYc0o kYc0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64 miri64 merged commit 944a8d9 into RIOT-OS:master Jan 19, 2017
@smlng smlng deleted the pr/pkg/tinydtls_compile_errors branch May 31, 2017 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kYc0o kYc0o kYc0o approved these changes

Assignees

@kYc0o kYc0o

Labels

Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR OS: Mac OS X Host OS: This PR/issue concerns usage of RIOT with Mac OS X as a host system Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smlng @kYc0o @miri64