Skip to content

CI Jenkins: activate macOS#6341

Closed
smlng wants to merge 1 commit intoRIOT-OS:masterfrom
smlng:pr/ci/activate_macos
Closed

CI Jenkins: activate macOS#6341
smlng wants to merge 1 commit intoRIOT-OS:masterfrom
smlng:pr/ci/activate_macos

Conversation

@smlng
Copy link
Copy Markdown
Member

@smlng smlng commented Jan 13, 2017

this PR activates macOS as a build target in Jenkins CI.

However there are several errors to fix first, hence this PR is currently based on #6326 and #6333, more to come ...

@smlng smlng added Area: CI Area: Continuous Integration of RIOT components OS: Mac OS X Host OS: This PR/issue concerns usage of RIOT with Mac OS X as a host system State: waiting for other PR State: The PR requires another PR to be merged first labels Jan 13, 2017
@smlng smlng force-pushed the pr/ci/activate_macos branch 3 times, most recently from 45ca82f to b18c3ea Compare January 13, 2017 10:10
@smlng smlng changed the title CI Jenkins: activate macos CI Jenkins: activate macOS Jan 13, 2017
@smlng
Copy link
Copy Markdown
Member Author

smlng commented Jan 13, 2017

needs #6351, too

[edit]: and #6352

[edit2] #6364

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Jan 18, 2017

rebased on latest master, but still depends on other PRs

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Jan 19, 2017

put #6399 on the list of dependencies ...

@smlng smlng force-pushed the pr/ci/activate_macos branch from 582981d to 0ea9a37 Compare January 19, 2017 16:37
@smlng smlng added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Jan 19, 2017
@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 19, 2017

Jenkins doesn't show any results for MacOSX (unless I'm missing something)

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Jan 20, 2017

@miri64 triggered Jenkins again, now it shows all green lights

@smlng smlng added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 20, 2017
@miri64
Copy link
Copy Markdown
Member

miri64 commented Jan 20, 2017

Click -> Ctrl+f -> "mac" -> 0 of 0. :-/

@smlng smlng force-pushed the pr/ci/activate_macos branch from 0ea9a37 to 8d434c4 Compare January 20, 2017 12:48
@smlng smlng removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 20, 2017
@smlng smlng force-pushed the pr/ci/activate_macos branch from 8d434c4 to 0bb84fc Compare January 20, 2017 13:36
@smlng
Copy link
Copy Markdown
Member Author

smlng commented Jan 20, 2017

requires #6440

@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Feb 3, 2017

Got it, do we have a "DO NOT MERGE" label?

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Feb 3, 2017

WIP?

[edit] that's why I set that

@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Feb 3, 2017

OK.

@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Feb 3, 2017

It needs a rebase BTW.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Feb 3, 2017

Also the faild CIs give a good hint to not merge this too ;-)

@smlng smlng force-pushed the pr/ci/activate_macos branch from 35a1c16 to 9015020 Compare February 3, 2017 14:16
@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Feb 3, 2017

Jenkins failed because of #4058

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Feb 3, 2017

@kYc0o nope that was fixed in #6534, hence I rebased, but other issues might prevail, see #6473

@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Feb 3, 2017

Yes I know, that's why I suggested the rebase, since I know #6534 got merged meanwhile, so I just mentioned that was the reason of the failure.

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Feb 3, 2017

@kYc0o Jenkins is happy. What about your list in #6473, close that issue?

@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Feb 3, 2017

The things on my list correspond rather to warnings which will be raised for other drivers that are excluded on native.

I suggest to keep the issue open until #1121 will be merged.

@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Feb 3, 2017

BTW, why relic works? Is thus test built on real macOS host or just clang?

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Feb 3, 2017

@kYc0o IIRC relic is only used by tests/unittests/test_relic, but its build on bare metal macOS using clang - with success.

@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Feb 4, 2017

Well, in my Mac it doesn't work...

snake:unittests facosta$ make tests-relic
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Building application "tests_unittests" for "native" with MCU "native".

"/Applications/Xcode.app/Contents/Developer/usr/bin/make" -C /Users/facosta/git/RIOT2/RIOT/pkg/relic
rm -Rf /Users/facosta/git/RIOT2/RIOT/tests/unittests/bin/pkg/native/relic
mkdir -p /Users/facosta/git/RIOT2/RIOT/tests/unittests/bin/pkg/native/relic
/Users/facosta/git/RIOT2/RIOT/dist/tools/git/git-cache clone "https://github.com/relic-toolkit/relic.git" "cdcfaeef101d18c3231c3b46359c519dd72682e8" "/Users/facosta/git/RIOT2/RIOT/tests/unittests/bin/pkg/native/relic"
Cloning into '/Users/facosta/git/RIOT2/RIOT/tests/unittests/bin/pkg/native/relic'...
remote: Counting objects: 16213, done.
remote: Total 16213 (delta 0), reused 0 (delta 0), pack-reused 16213
Receiving objects: 100% (16213/16213), 3.69 MiB | 1.35 MiB/s, done.
Resolving deltas: 100% (13018/13018), done.
Checking connectivity... done.
HEAD is now at cdcfaee... Fix cycle counter in ARM.
touch /Users/facosta/git/RIOT2/RIOT/tests/unittests/bin/pkg/native/relic/.git-downloaded
git -C /Users/facosta/git/RIOT2/RIOT/tests/unittests/bin/pkg/native/relic checkout -f cdcfaeef101d18c3231c3b46359c519dd72682e8
HEAD is now at cdcfaee... Fix cycle counter in ARM.
git -C /Users/facosta/git/RIOT2/RIOT/tests/unittests/bin/pkg/native/relic am --ignore-whitespace "/Users/facosta/git/RIOT2/RIOT/pkg/relic"/patches/*.patch
Applying: fixed signedness of counter variable
Applying: don't redefine ALIGN
Applying: require only CMake version 2.8
touch /Users/facosta/git/RIOT2/RIOT/tests/unittests/bin/pkg/native/relic/.git-patched
./fix-util_print_wo_args.sh /Users/facosta/git/RIOT2/RIOT/tests/unittests/bin/pkg/native/relic
sed: RE error: illegal byte sequence
make[1]: *** [fix_source] Error 1
make: *** [/Users/facosta/git/RIOT2/RIOT/tests/unittests/bin/native/relic.a] Error 2

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Feb 5, 2017 via email

@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Feb 6, 2017

Yes, I'm on current master and it shows that error. Have you manually configured your LANG settings? I've never touched them...

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Feb 7, 2017

@kYc0o as said the helper script in pkg/relic/os_util.sh was added to fix params of sed command and the LANG settings. I did not tamper with that either and haven't had these problems since then ...

@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Feb 7, 2017

So you suggest me to run that script to remove that error or you mean that the script should run by itself while adding the pkg?

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Feb 7, 2017

actually its the latter, so I'm a bit confused why it doesn't work for you. It does on our macOS Jenkins slave, on my MacBook and my other Mac, too. I haven't changed any language settings and sed is the macOS native one. But I use Homebrew on my machines, maybe that changes some environment settings?

@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Feb 7, 2017

I'd say let's merge and let me deal with my problem, since it seems it only happens on my system. Moreover, I think this is more important for Jenkins, and since he's happy, I think it's fine. So go!

@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Feb 7, 2017

I let @cgundogan merge it when he thinks it's OK.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Feb 16, 2017

Ping @cgundogan?

@smlng
Copy link
Copy Markdown
Member Author

smlng commented Feb 16, 2017

I'll close this one as memo, we currently do not have sufficient resources to build every PR on macOS. However, for the planned master periodic/nightly build it should be included.

As an alternative, I'd like to get llvm toolchain supported in Jenkins and enabled for every PR see #6600.

@smlng smlng closed this Feb 16, 2017
@smlng smlng added State: archived State: The PR has been archived for possible future re-adaptation and removed State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels Feb 16, 2017
@smlng smlng deleted the pr/ci/activate_macos branch May 31, 2017 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: CI Area: Continuous Integration of RIOT components OS: Mac OS X Host OS: This PR/issue concerns usage of RIOT with Mac OS X as a host system State: archived State: The PR has been archived for possible future re-adaptation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants