based on #6258 and #6333

this PR is (re)based on #6333

to clarify what its doing: running certain tests on macOS revealed a name clash in the make system when a test has an APPLICATION variable in its Makefile that is the same as a package required with USEPKG; i.e. this happened with tests/libfixmath, tests/lwip, and tests/pkg_tiny-asn1.

I resolved it by prefixing the APPLCIATION variable with test_, for the sake of consistency I applied this scheme to all other tests as well ...

There's a way to build all the tests at once?

@kYc0o yes: murdock or jenkins 😁 btw. Jenkins is fine with the changes.

you could also run:

cd tests;
for i in $(ls); do echo $i; make -C $i; done

@kYc0o also note that this PR depends on #6333

[edit]: so do not merge before that one

Well this PR changes every test's name but strangely some tests build without this change, for instance bloom_bytes... Did you had the errors for all the tests you've modified?

nope, as said above:

for the sake of consistency I applied this scheme to all other tests as well ...

Back to the past then?

Maybe wait for @Kijewski with this one what he thinks about reverting #1502 ;-)

Well, this PR only reverts the renaming of the application, not the renaming of the folder which is okay, I think. I am more confused that we still have this name clash between RIOT and application code - I thought we solved this long ago.

mhm, wasn't aware of #1502 ... it seems that name clashes are only an issue on macOS, not Linux.

However I don't think its bad to have the APPLICATION variable of tests to be prefixed by test_, and would further suggest to add example_ to all examples.

But, for now I only want to fix macOS to get it into Jenkins with green build status 😄

Out of curiosity: do you understand why it is failing on OSX?

not exactly, but I don't think its clang - its the version of make on macOS. I didn't dig any deeper into the build system of RIOT, I think others are more familiar with that, @kaspar030 maybe?

As said before, it must be some clash with the APPLICATIONS and USEPKG variables in a Makefile. For instance tests/libfixmath failed where APPLICATION = libfixmath and USEPKG = libfixmath are present, while tests/libfixmath_unittests does not fail, prefixing the former to have APPLICATION = test_libfixmath solved the problem. Same thing for tests/lwip and tests/tiny-asn1, both had APPLICATION and USEPKG with the same name in their Makefiles.

edit:

the result is that the main of the application is not build (due to the same name with package) and hence not found by the linker. Further, this problem only pops up with packages not with modules (USEMODULE) of the same name as APPLICATION - atleast I haven't observer that.

@OlegHahm any objections? Otherwise this should go into the release. Btw. CI is happy, too

rebased without depending on other PR now

Murdock succeeded and Jenkins failed, though from the Webview it isn't clear why.

maybe some changes in the CI server infrastructure and the job got stuck, Jenkins is in parts WIP. Anyway, rescheduled on Jenkins - if Murdock is fine, Jenkins should/will be, too.

🍵 and wait ...

rebased

Needs rebase again.

For the record: I don't object this PR.

Since #1502 we made some changes to the make system which disallows two modules sharing the same name. So this PR seems to be indeed needed. But maybe it would be enough to edit tests/Makefile.tests_common, not every tests/*/Makefile?

rebased, lets wait for CI ...

done! Lets see if CI is happy