Skip to content

cpu/stm32x: unified UART driver implementations#6187

Merged
haukepetersen merged 3 commits intoRIOT-OS:masterfrom
haukepetersen:opt_stm32_uart
Jan 6, 2017
Merged

cpu/stm32x: unified UART driver implementations#6187
haukepetersen merged 3 commits intoRIOT-OS:masterfrom
haukepetersen:opt_stm32_uart

Conversation

@haukepetersen
Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen commented Dec 7, 2016 •
edited
Loading

Now finally also a shared UART implementation for all the stm32x CPUs.

This PR shares two commits with #6186 (centralizing of periph_apb_clk).

NOTE: Currently I dropped the DMA support (offered previously by stm32f2 and stm32f4). Especially when used with STDIO and then using printf/puts from ISR context, this was not the best idea to enable by default anyway... I plan to re-add this functionality again in a separate PR (together with a stm32x wide concept for DMA handling).

@haukepetersen haukepetersen added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation State: waiting for other PR State: The PR requires another PR to be merged first labels Dec 7, 2016
@haukepetersen haukepetersen added this to the Release 2017.01 milestone Dec 7, 2016
@haukepetersen haukepetersen mentioned this pull request Dec 8, 2016
Closed
@haukepetersen haukepetersen added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 13, 2016
@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Dec 15, 2016

restarted Murdock (as he was confused by the 'waiting for other PR' label)

A-Paul
A-Paul reviewed Dec 16, 2016
View reviewed changes
boards/f4vi1/include/periph_conf.h

/**
* @name UART configuration
* @brief UART configuration
Copy link
Copy Markdown
Member

@A-Paul A-Paul Dec 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this also in other PRs. What is the deal with this extra space?

Copy link
Copy Markdown
Member

@miri64 miri64 Dec 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, check if this parses still correctly. Without the name the sectioning in the doc often isn't correct anymore (and the brief of the group is added to the first element)

Copy link
Copy Markdown
Contributor Author

@haukepetersen haukepetersen Dec 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I have never spend much thought on this -> I have been using brief for everything for the last 2 years I think...

About the spaces: they are there to have a unified indention in a doc comment, so if you use e.g. return, note, and brief in one block, their texts all start at the same col.

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Dec 16, 2016

rebased

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Dec 19, 2016

rebased again

@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 19, 2016
@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Dec 20, 2016

fixed some issue with the c++ compiler and rebased.

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Dec 28, 2016

needs rebase

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Jan 5, 2017

rebased

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Jan 5, 2017

Successfully tested on 3 nucleo boards : nucleo-f030, nucleo-f070 and nucleo-f401

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Jan 5, 2017

@kYc0o: could you be so nice and test on the iotlab-m3? Thx

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Jan 5, 2017

@kYc0o, @haukepetersen, just tested iotlab-m3 : the shell works.

Also tested all nucleo boards except f091, f207 and f334 => OK

I tend to give an ACK.

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Jan 5, 2017

Me too :-)

aabadie
aabadie approved these changes Jan 6, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give an ACK on this one. I tested on all the board I have here and all worked well.

@haukepetersen haukepetersen merged commit ade8bd2 into RIOT-OS:master Jan 6, 2017
@vincent-d vincent-d mentioned this pull request Jan 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miri64 miri64 miri64 left review comments

@aabadie aabadie aabadie approved these changes

+1 more reviewer

@A-Paul A-Paul A-Paul left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@aabadie aabadie

@PeterKietzmann PeterKietzmann

@A-Paul A-Paul

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@haukepetersen @aabadie @miri64 @A-Paul @kaspar030 @PeterKietzmann