Skip to content

boards/nucleo-f410: initial support#6025

Merged
kYc0o merged 3 commits intoRIOT-OS:masterfrom
aabadie:nucleo_f410
Mar 15, 2017
Merged

boards/nucleo-f410: initial support#6025
kYc0o merged 3 commits intoRIOT-OS:masterfrom
aabadie:nucleo_f410

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Oct 30, 2016 •
edited
Loading

We have plenty of nucleo boards. This PR ports nucleo64 f410 to RIOT.

Contrary to other STM32f4 already available in RIOT, the STM32f410rb RCC peripheral doesn't use the same register for RNG. I made a small change to make this configurable in the periph_cpu.h file.

@aabadie aabadie changed the title Nucleo f410 boards/nucleo-f410: initial support Oct 30, 2016
@OlegHahm OlegHahm added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Oct 30, 2016
@OlegHahm OlegHahm added this to the Release 2017.01 milestone Oct 30, 2016
haukepetersen
haukepetersen reviewed Oct 31, 2016
View reviewed changes
cpu/stm32f4/periph/timer.c Outdated

void TIMER_0_ISR(void)
{
#if TIMER_0_EN
Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen Oct 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to

#ifdef TIMER_0_ISR
void TIMER_0_ISR(void) 
{
    irq_handler(TIMER_0, TIMER_0_DEV);
}
#endif

@haukepetersen
Copy link
Copy Markdown
Contributor

haukepetersen commented Oct 31, 2016

Appart from the minor remark I think everything is in order here..

@PeterKietzmann PeterKietzmann added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 20, 2016
@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Nov 20, 2016

Looks fine though I'd like to check hwrng on stm32f4 before merge. Already started Murdock.

@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Nov 21, 2016

@aabadie relic unittests overflow ROM on that device. Please blacklist.

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Nov 24, 2016

@PeterKietzmann, updated the tests. Let's see what Murdock says.
I tested the port on hardware : it works but requires openocd 0.10...

@aabadie aabadie force-pushed the nucleo_f410 branch 2 times, most recently from 7fdd0b6 to 87aea7a Compare November 29, 2016 14:59
@PeterKietzmann PeterKietzmann added the State: waiting for other PR State: The PR requires another PR to be merged first label Nov 29, 2016
@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Nov 29, 2016 •
edited
Loading

@aabadie let's wait for #4780. Otherwise @haukepetersen's todo list with SPI rework will grow bigger and bigger. Sorry for the delay

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Nov 30, 2016

@PeterKietzmann np the delay due to #4780 was expected.

@PeterKietzmann PeterKietzmann modified the milestones: Release 2017.01, Release 2017.04 Jan 26, 2017
@aabadie aabadie removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR State: waiting for other PR State: The PR requires another PR to be merged first labels Feb 3, 2017
@aabadie aabadie force-pushed the nucleo_f410 branch 2 times, most recently from b967fea to ae16b6b Compare February 3, 2017 13:58
@aabadie aabadie mentioned this pull request Feb 20, 2017
Open
@astralien3000
Copy link
Copy Markdown
Member

astralien3000 commented Feb 28, 2017

No PWM is configured, I guess it is normal.

I tested :

  • examples/hello_world
  • examples/default (saul LED+BUTTON)
  • tests/periph_uart
  • tests/periph_timer
  • tests/periph_hwrng
  • tests/xtimer_msg

Everything is OK.

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Feb 28, 2017

No PWM is configured, I guess it is normal.

We could configure some on the ST Morpho connectors but none are available on the arduino connectors.

@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Feb 28, 2017

Is this a nucleo32, 64, 144? should be in the folder's name?

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Feb 28, 2017

Is this a nucleo32, 64, 144? should be in the folder's name?

nucleo 64. This is the implicit convention I choosed (see comment):

  • nucleo32 -> 32 pins version (Arduino nano compatible)
  • nucleo -> 64 pins version (Arduino connectors + ST morpho connectors)
  • nucleo144 -> 144 pins version

@kYc0o kYc0o added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 28, 2017
@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Feb 28, 2017

Why did Jenkins build this correctly?

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Feb 28, 2017

Why did Jenkins build this correctly?

Maybe it didn't trigger a new build in case of a conflict.
Anyway, I rebased. Let's see if it's green again now.

@aabadie aabadie force-pushed the nucleo_f410 branch 2 times, most recently from 8a4151e to 225f579 Compare March 2, 2017 22:41
@aabadie aabadie mentioned this pull request Mar 6, 2017
Merged
@aabadie aabadie force-pushed the nucleo_f410 branch 2 times, most recently from 501cd88 to d437e82 Compare March 14, 2017 17:10
kYc0o
kYc0o approved these changes Mar 15, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@kYc0o kYc0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@kYc0o kYc0o merged commit 1a17955 into RIOT-OS:master Mar 15, 2017
@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Mar 15, 2017

Ups, I think this broke #6740. Can you re-sort alphabetically the BOARDS_INSUFFICIENT_MEMORY in tests/unittests and relic?

@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Mar 15, 2017

@kYc0o good catch. For unittest, it's ok not for relic.

@aabadie aabadie mentioned this pull request Mar 15, 2017
Merged
@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Mar 15, 2017

@kYc0o, I opened #6746

@aabadie aabadie deleted the nucleo_f410 branch February 26, 2018 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haukepetersen haukepetersen haukepetersen left review comments

@kYc0o kYc0o kYc0o approved these changes

Assignees

@DipSwitch DipSwitch

@PeterKietzmann PeterKietzmann

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2017.04

Development

Successfully merging this pull request may close these issues.

8 participants

@aabadie @haukepetersen @PeterKietzmann @astralien3000 @kYc0o @kaspar030 @DipSwitch @OlegHahm