dist: tools: jlink.sh: use printf for JLINK_*_FLASH to allow use of backslash#5900
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Oct 3, 2016
Merged
Conversation
kaspar030
added
Type: enhancement
Contributor
Author
|
Checking the Murdock/CI error, the arm7 and Cortex-m ones are due to missing tlsf-3.0.zip and x86 errors are a combination of the same and newlib missing from from http://download.riot-os.org/i586-newlib_2.2.0.20150623_tlsf-3337.tar.bz2 |
Member
|
same as #5564: This has nothing to do with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need JLINK_*_FLASH variables to contain escaped character line "\n" so we can have multiple lines added to the flashing script.
Appropriate way to do that is to replace echo by printf as is not portable between dash and bash to provide such support.