Skip to content

sys: remove config module#5756

Merged
LudwigKnuepfer merged 1 commit intoRIOT-OS:masterfrom
kaspar030:remove_config
Aug 27, 2016
Merged

sys: remove config module#5756
LudwigKnuepfer merged 1 commit intoRIOT-OS:masterfrom
kaspar030:remove_config

Conversation

@kaspar030
Copy link
Copy Markdown
Contributor

IMHO this module is unmaintained and unused... Do we still need it?

@kaspar030 kaspar030 added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Aug 17, 2016
@kaspar030 kaspar030 mentioned this pull request Aug 17, 2016
@kaspar030 kaspar030 added the Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR label Aug 17, 2016
@OlegHahm
Copy link
Copy Markdown
Member

👍 for removing this, but we definitely need a replacement.

@jnohlgard
Copy link
Copy Markdown
Member

I suggest a vfs or nvram based replacement. that should go in a separate PR
though.

Den 18 aug. 2016 10:46 AM skrev "Oleg Hahm" [email protected]:

👍 for removing this, but we definitely need a replacement.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#5756 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AATYQkrvOuFu4BRywS6gixIHrIENI4Rdks5qhBvJgaJpZM4Jm18w
.

@OlegHahm
Copy link
Copy Markdown
Member

Sounds a bit like overkill to me. Think of MSP430 and its INFOMEM (a small flash section, intended to store persistent device specific information).

@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Aug 19, 2016

So should we close this #162 issue?

@miri64
Copy link
Copy Markdown
Member

miri64 commented Aug 19, 2016

Sounds a bit like overkill to me. Think of MSP430 and its INFOMEM (a small flash section, intended to store persistent device specific information).

Why would it be overkill to implement a very simple read-only vfs backend for this and make it something comparible to /proc or /sys on Linux? I think this only would provide more consistency to more powerful platforms if they provide something like this as well.

@OlegHahm
Copy link
Copy Markdown
Member

A whole filesystem to store some bytes in a persistent way sounds certainly like overkill to me and I don't see any benefit.

@jnohlgard
Copy link
Copy Markdown
Member

@OlegHahm I didn't mean a whole file system for a config store. What I meant is that the implementation should be either an NVRAM device, or a file-like persistent memory using the VFS API. Using familiar APIs such as vfs_read/write would just make it easier to use from an application developer point of view.
The "file system" driver does not need to support multiple files, just a single file which is the interface to the backing memory. Similar to what a /dev/sdx device does in Linux.

@LudwigKnuepfer
Copy link
Copy Markdown
Member

I guess it is worthwhile to move the discussion about what to do as a replacement to a dedicated issue.

@jnohlgard
Copy link
Copy Markdown
Member

I agree, I think since this PR has been open for more than a week, I don't think anyone will mind that we remove this module until a replacement is ready.

@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 26, 2016
@kaspar030
Copy link
Copy Markdown
Contributor Author

  • fixed last build errors, squashed

@LudwigKnuepfer
Copy link
Copy Markdown
Member

ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants