gnrc_udp: add missing duplitation step#5749
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Aug 30, 2016
Merged
Conversation
miri64
added
Type: bug
This was referenced Aug 15, 2016
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Aug 22, 2016
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Aug 25, 2016
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Aug 26, 2016
miri64
added a commit
to miri64/RIOT
that referenced
this pull request
Aug 26, 2016
miri64
added
the
Community: Hack'n'ACK candidate
Member
|
Looks fine to me, ACK from my side. @kYc0o any objections? |
miri64
added
the
CI: ready for build
Contributor
|
Everything was Ok. Sorry for the delay. |
Member
|
Nice catch! |
miri64
added
Platform: MSP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment UDP is duplicating the UDP header wrong, in case
pkt->users > 1.Current behavior:
With this fix:
The previous behavior leads to the original UDP header to be removed from the packet buffer too early (and subsequently resulting in a crash), because its users counter is one less than expected, while the dangling UDP header never gets removed.