gnrc_netreg: mbox and arbitrary callback support by miri64 · Pull Request #5526 · RIOT-OS/RIOT

miri64 · 2016-06-07T12:12:15Z

Adds dispatch capabilities to gnrc_netapi/gnrc_netreg other than target threads. This is optional behavior. The new target types introduced are:

mbox (see core: mbox: initial commit #4919)
arbitrary callbacks providing both TYPE and pkt

Depends on ~~#5524~~ (merged), ~~#5525~~ (merged), and ~~#4919~~ (merged)

miri64 · 2016-06-07T12:24:21Z

The callback idea was mainly to have some experiments done (and maybe future option provided) to run GNRC in a single thread.

miri64 · 2016-06-07T12:27:19Z

And it can also be used to implement receive callbacks in conn very slim (see #5091)

miri64 · 2016-08-05T15:21:53Z

Rebased to current master.

miri64 · 2016-08-11T13:21:10Z

Fixed some errors.

miri64 · 2016-08-12T12:19:24Z

Rebased to current dependencies

miri64 · 2016-08-25T12:29:33Z

Rebased to current #5524 (as it is the only remaining dependency) and squashed.

miri64 · 2016-08-26T12:01:53Z

Rebased to current #5524 and fixed a missing change.

kaspar030 · 2016-09-27T21:16:13Z

Quite a lot of changes, and I don't know gnrc well enough. Will reassign.

miri64 · 2016-10-18T13:00:26Z

Needed for #5772, so added to release.

miri64 · 2016-10-25T16:49:37Z

Rebased to current #5526

cgundogan · 2016-10-25T18:17:21Z

Makefile.dep

  USEMODULE += gnrc_udp
 endif

+ifneq (,$(filter gnrc_netreg_extra,$(USEMODULE)))


what was the idea behind the name gnrc_netreg_extra? I somehow fail to see the relation to what this PR actually does (add other dispatch capabilities with mbox, instead of threads)

Well the _extra module pulls in the mbox and callback functionality.

I can fix it up to devide it into two modules, but the complexity is growing in both instances.

Introduced two pseudomodule with a better name.

haukepetersen · 2016-10-25T18:29:23Z

looks valid to me, the only thing is the name of the MODULE_GNRC_NETREG_EXTRA module. I would prefer MODULE_GNRC_NETAPI_EXTRA, as this is the more general term and in the end this PR provides us with more flexibility when using netapi.

haukepetersen

ACK once Murdock agrees

haukepetersen · 2016-10-25T19:07:25Z

Oh, and of course once squashed and rebased...

miri64 · 2016-10-25T19:08:29Z

will wait for #5524 to get merged with the squash (+ rebase), so I can cleanly rebase #5772 on this one.

miri64 · 2016-10-25T19:36:21Z

Rebased and squashed

miri64 · 2016-10-25T20:17:53Z

Fixed issue in tests/slip and squashed immediately.

cgundogan · 2016-10-25T20:59:43Z

Murdock is happy => GO

PR RIOT-OS#5526 introduced mbox support for netreg so using these functions is now required.

miri64 added Area: network Area: Networking Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. State: waiting for other PR State: The PR requires another PR to be merged first GNRC labels Jun 7, 2016

miri64 assigned kaspar030 Jun 7, 2016

miri64 mentioned this pull request Jun 8, 2016

conn: Simplify and overhaul conn API #5533

Closed

miri64 force-pushed the gnrc_netreg/api/mbox-extension branch from c33ddbd to 4ff370c Compare August 5, 2016 15:21

miri64 force-pushed the gnrc_netreg/api/mbox-extension branch from 5e4f6a5 to fb93fae Compare August 5, 2016 16:13

miri64 force-pushed the gnrc_netreg/api/mbox-extension branch 2 times, most recently from 6a613e7 to 313ca9d Compare August 12, 2016 12:19

miri64 added a commit to miri64/RIOT that referenced this pull request Aug 22, 2016

Merge branch 'gnrc_netreg/api/mbox-extension' (RIOT-OS#5526) into HEAD

fcafe3f

miri64 mentioned this pull request Aug 23, 2016

Proposed changes on sock TCP interface miri64/RIOT#29

Closed

miri64 force-pushed the gnrc_netreg/api/mbox-extension branch from 880d9b3 to b6c0c80 Compare August 25, 2016 12:29

miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 25, 2016

miri64 added a commit to miri64/RIOT that referenced this pull request Aug 25, 2016

Merge branch 'gnrc_netreg/api/mbox-extension' (RIOT-OS#5526) into HEAD

57434aa

miri64 added a commit to miri64/RIOT that referenced this pull request Aug 26, 2016

Merge branch 'gnrc_netreg/api/mbox-extension' (RIOT-OS#5526) into HEAD

7c55576

miri64 mentioned this pull request Aug 26, 2016

gnrc_sock: provide port for sock_ip and sock_udp #5772

Merged

miri64 force-pushed the gnrc_netreg/api/mbox-extension branch from b6c0c80 to ae85de7 Compare August 26, 2016 12:01

miri64 added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Aug 26, 2016

miri64 added a commit to miri64/RIOT that referenced this pull request Aug 26, 2016

Merge branch 'gnrc_netreg/api/mbox-extension' (RIOT-OS#5526) into HEAD

0557070

miri64 added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Aug 30, 2016

kaspar030 removed their assignment Sep 27, 2016

miri64 added this to the Release 2016.10 milestone Oct 18, 2016

miri64 force-pushed the gnrc_netreg/api/mbox-extension branch from ae85de7 to 2fced10 Compare October 25, 2016 16:49

miri64 removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 25, 2016

cgundogan reviewed Oct 25, 2016

View reviewed changes

haukepetersen approved these changes Oct 25, 2016

View reviewed changes

miri64 added 2 commits October 25, 2016 21:31

gnrc_netreg: add mbox support

b84d955

gnrc_netreg: add arbitrary callback support

97adff5

miri64 force-pushed the gnrc_netreg/api/mbox-extension branch from 25d4472 to 8c7ce02 Compare October 25, 2016 19:36

all: fix for new netreg_entry_t structure

0016463

miri64 force-pushed the gnrc_netreg/api/mbox-extension branch from 8c7ce02 to 0016463 Compare October 25, 2016 20:17

cgundogan merged commit a74f429 into RIOT-OS:master Oct 25, 2016

miri64 deleted the gnrc_netreg/api/mbox-extension branch October 25, 2016 21:03

miri64 mentioned this pull request Oct 29, 2016

TinyDTLS integrated to RIOT (without sockets) #5395

Merged

miri64 added a commit to miri64/RIOT that referenced this pull request Nov 3, 2016

gcoap: use generic netreg initializers

dc907b7

PR RIOT-OS#5526 introduced mbox support for netreg so using these functions is now required.

miri64 mentioned this pull request Nov 3, 2016

gcoap: use generic netreg initializers #6047

Merged

miri64 added a commit to miri64/RIOT that referenced this pull request Nov 3, 2016

gcoap: use generic netreg initializers

280dfb2

PR RIOT-OS#5526 introduced mbox support for netreg so using these functions is now required.

samkumar pushed a commit to samkumar/RIOT-OS that referenced this pull request Nov 7, 2016

gcoap: use generic netreg initializers

badbd19

PR RIOT-OS#5526 introduced mbox support for netreg so using these functions is now required.

rzr pushed a commit to TizenTeam/RIOT that referenced this pull request Nov 8, 2016

gcoap: use generic netreg initializers

550dc14

PR RIOT-OS#5526 introduced mbox support for netreg so using these functions is now required.

jnohlgard mentioned this pull request Nov 10, 2016

sniffer: Update to follow gnrc_netreg_entry_t API change RIOT-OS/applications#28

Merged

Conversation

miri64 commented Jun 7, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miri64 commented Jun 7, 2016

Uh oh!

miri64 commented Jun 7, 2016

Uh oh!

miri64 commented Aug 5, 2016

Uh oh!

miri64 commented Aug 11, 2016

Uh oh!

miri64 commented Aug 12, 2016

Uh oh!

miri64 commented Aug 25, 2016

Uh oh!

miri64 commented Aug 26, 2016

Uh oh!

kaspar030 commented Sep 27, 2016

Uh oh!

miri64 commented Oct 18, 2016

Uh oh!

miri64 commented Oct 25, 2016

Uh oh!

cgundogan Oct 25, 2016

Choose a reason for hiding this comment

Uh oh!

miri64 Oct 25, 2016

Choose a reason for hiding this comment

Uh oh!

miri64 Oct 25, 2016

Choose a reason for hiding this comment

Uh oh!

miri64 Oct 25, 2016

Choose a reason for hiding this comment

Uh oh!

haukepetersen commented Oct 25, 2016

Uh oh!

haukepetersen left a comment

Choose a reason for hiding this comment

Uh oh!

haukepetersen commented Oct 25, 2016

Uh oh!

miri64 commented Oct 25, 2016

Uh oh!

miri64 commented Oct 25, 2016

Uh oh!

miri64 commented Oct 25, 2016

Uh oh!

cgundogan commented Oct 25, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

miri64 commented Jun 7, 2016 •

edited

Loading