Skip to content

gnrc_netreg: introduce helper macro/function for entry init#5524

Merged
haukepetersen merged 2 commits intoRIOT-OS:masterfrom
miri64:gnrc_netreg/api/helper-macro
Oct 25, 2016
Merged

gnrc_netreg: introduce helper macro/function for entry init#5524
haukepetersen merged 2 commits intoRIOT-OS:masterfrom
miri64:gnrc_netreg/api/helper-macro

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Jun 7, 2016

This introduces a helper macro/function for gnrc_netreg_entry_t initialization, similar like the ones in mutex.h.

This is a preparation step for mbox (see #4919) integration into GNRC

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking GNRC labels Jun 7, 2016
This was referenced Jun 7, 2016
Merged
Merged
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 5, 2016
@miri64 miri64 force-pushed the gnrc_netreg/api/helper-macro branch 2 times, most recently from 9d96d70 to dcd92cd Compare August 25, 2016 12:24
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Aug 25, 2016

Rebased to current master and squashed.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Aug 26, 2016

Missed some instances of setting (hope the introduction of the patch to CCN-lite is alright, I don't want to wait for upstream).

@miri64 miri64 added CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties labels Aug 26, 2016
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 26, 2016

Rebased to current master.

@miri64 miri64 force-pushed the gnrc_netreg/api/helper-macro branch from 42cb275 to 3ecf91f Compare September 26, 2016 14:01
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Sep 27, 2016

Missed some instances of setting (hope the introduction of the patch to CCN-lite is alright, I don't want to wait for upstream).

Sorry, should have looked at this earlier. Usually, the time to get things into CCN-lite upstream is less than < 1 week - particular if only the RIOT adapter is affected.

However, a) I don't object a patch in general, but I would try to get rid of it ASAP again and b) I think we/I should seriously reconsider to move most of the CCN-lite RIOT adapter functionality into the RIOT repository.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 27, 2016

However, a) I don't object a patch in general, but I would try to get rid of it ASAP again and b) I think we/I should seriously reconsider to move most of the CCN-lite RIOT adapter functionality into the RIOT repository.

I prefer (b). That's similar to how I handled lwIP.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Oct 6, 2016

@OlegHahm ping?

@miri64 miri64 mentioned this pull request Oct 13, 2016
Merged
@miri64 miri64 added this to the Release 2016.10 milestone Oct 18, 2016
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Oct 18, 2016

Needed for #5772, so added to Release.

@haukepetersen haukepetersen added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 25, 2016
@haukepetersen
Copy link
Copy Markdown
Contributor

haukepetersen commented Oct 25, 2016

looks, good, please squash and run Murdock

@miri64 miri64 force-pushed the gnrc_netreg/api/helper-macro branch from 3ecf91f to dc45cd2 Compare October 25, 2016 16:47
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable labels Oct 25, 2016
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Oct 25, 2016

Done

@BytesGalore
Copy link
Copy Markdown
Member

BytesGalore commented Oct 25, 2016

tested with gnrc_networking example on native -> ACK

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Oct 25, 2016

It's just the squashing label... can we just merge to not wait another 3h?

@haukepetersen
Copy link
Copy Markdown
Contributor

haukepetersen commented Oct 25, 2016

Yes, and go.

@haukepetersen haukepetersen merged commit bc232a5 into RIOT-OS:master Oct 25, 2016
@miri64 miri64 deleted the gnrc_netreg/api/helper-macro branch October 25, 2016 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@BytesGalore BytesGalore BytesGalore approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@OlegHahm OlegHahm

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2016.10

Development

Successfully merging this pull request may close these issues.

4 participants

@miri64 @OlegHahm @haukepetersen @BytesGalore