boards: add arduino uno and duemilanove support by mali · Pull Request #5451 · RIOT-OS/RIOT

mali · 2016-05-18T19:00:27Z

Add basic support of :
- atmega328p MCU
- arduino uno board

kaspar030 · 2016-05-18T19:06:31Z

boards/arduino-uno/board.c

+/*
+ * Copyright (C) 2014 Freie Universität Berlin, Hinnerk van Bruinehsen
+ *               2015 Kaspar Schleiser <[email protected]>
+ *  		 2016 Laurent Navet <[email protected]>


indentation off

aabadie · 2016-05-19T07:29:39Z

cpu/atmega328p/periph/uart.c

+            UART0_RX_IRQ_EN;
+            break;
+#endif /* UART_0_EN */
+#if UART_1_EN


There's only one UART on this CPU, so the code referring to uart interfaces > 0 should be removed.

aabadie · 2016-05-19T07:56:29Z

Tested on an arduino uno, works if one change the PROGRAMMER variable to arduino. The stk500v2 seems to work for the duemilanove board which is similar to the Uno.
Maybe someone has idea for elegantly solving this issue ?

Apart from that and the comment about the UART interfaces, this is a good job, thanks !

miri64 · 2016-05-19T08:05:35Z

Maybe someone has idea for elegantly solving this issue ?

Do it similar to the cortex-m platforms: make an (or multiple aptly named) arduino_common directory(s) and add only the bare minimum changes for arduino-uno or arduino-duemilanove to the respective directories.

aabadie · 2016-05-19T20:09:04Z

boards/arduino-uno/Makefile.include

+export DEBUGGER_FLAGS = "-x $(RIOTBOARD)/$(BOARD)/dist/gdb.conf $(ELFFILE)"
+export DEBUGGER = $(DIST_PATH)/debug.sh $(DEBUGSERVER_FLAGS) $(DIST_PATH) $(DEBUGSERVER_PORT)
+
+# PROGRAMMER defaults to stk500v2 which is the internal flasher via USB. Can be


programmer needs to be updated in the comment as well

indeed, fixed

mali · 2016-05-20T21:19:30Z

Squashing Done.

kYc0o · 2016-05-21T11:26:10Z

Actually the squashing should be done when the review is done and the PR is ready to be merged. I put the label just to don't forget to do it... sorry if it made you think that the squashing was needed now...

mali · 2016-05-21T19:00:40Z

No problem, will squash again if needed :)

mali · 2016-05-25T19:36:39Z

I've added a patch that place shared code between atmega328p and atmega2560 in atmega_common.
except startup.c that certainly can be shared but I haven't found how yet (build fails for what I've tried now)

mali · 2016-06-02T19:40:14Z

Started a wiki page : https://github.com/RIOT-OS/RIOT/wiki/Board:-Arduino-Uno

kYc0o · 2016-06-07T16:03:00Z

Let's wait for #5529, it will simplify the code since only few modifications to the common sources will be needed.

PeterKietzmann · 2016-06-22T14:54:57Z

@mali #5529 was merged. Did you plan to implement a small port for the duemilanove as well?

mali · 2016-06-22T15:15:58Z

I can if you're interested, at least the duemilanove with the atmega328.
I don't have the atmega168 model.

PeterKietzmann · 2016-06-23T06:36:32Z

I don't want to force you. But I've got one duemilanove (atmega328) laying around which I never used before :-)

mali · 2016-06-23T07:31:26Z

For what I know the only difference between the two is that the Duemilanove uses a FTDI USB chip while the Uno uses a second Atmel who acts as USB-serial converter. So that should be simple

kYc0o · 2016-06-29T14:23:21Z

Just looked at the latest commits and you still have the cpu/atmega328p/periph folder, which is no more necessary, since all the peripherals work equally for all atmega CPUs. Can you remove it?

add atmega328p support with: uart, timer, spi and gpio

mali · 2016-09-05T19:12:01Z

@PeterKietzmann, you can remove dust from your duemilanove and test it :-)

mali · 2016-09-10T13:03:45Z

a video proof that it works.
A timer pulse which toggles gpio.

mali · 2016-09-19T12:37:20Z

I think all issues have been fixed.
Please let me know if you wait for something more before 2016.10 release.

aabadie · 2016-09-19T12:48:54Z

@mali. Just tested with an Arduino Uno (I don't have duemilanove) : it works fine.

I give an ACK. Let's now wait for Murdock.

aabadie · 2016-09-19T18:48:46Z

@mali, just in case you missed it, Murdock is complaining (search for "Errors" in the page pointed by "Details" above).
There are a few trailing whitespaces and a warning generated by doxygen.
To fix the coap test error, you have to add the arduino-uno/duemilanove to the BOARD_BLACKLIST list (see test/coap/Makefile fir example).
The remaining cortex_m4_2 and cortex_m3_1 errors don't seem to be related.

aabadie

@mali with the inline comment, doxygen warning should be fixed.
But I don't really understand what's wrong with the pipe test build failure (malloc.h missing). Maybe @kaspar030 has an idea ?

aabadie · 2016-09-20T07:18:08Z

boards/arduino-common/include/board.h

+ */
+
+/**
+ * @defgroup    boards_arduino-common


The doxygen warning triggering a Murdock error comes from this line (try make doc at the root of riot repository and look at the first warning).
To fix it, you can change it like this:

* @defgroup boards_arduino-common Arduino common

Done, thank's !

mali · 2016-09-20T20:22:49Z

Murdock is green :-)

aabadie

2 things remaining:

apply changes requested by the comment above
squash the commits

After that => ACK (again)

aabadie · 2016-09-21T07:03:43Z

tests/pthread/Makefile


 BOARD_BLACKLIST := arduino-mega2560 waspmote-pro
 # arduino-mega2560: unknown type name: clockid_t
+BOARD_BLACKLIST += arduino-uno arduino-duemilanove


arduino-uno and arduino-duemilanove boards are blacklisted for the same reason (unknown type clockid_t) so no need to add those 2 extra lines, you can just append them to the first line and update the comment above.
There are a other places were this should be changed.

Uno and Duemilanove(atmega328p version) are nearly the same boards. The only difference is that the Duemilanove use an FTDI usb chip, while the Uno use an Atmel which acts as USB/Serial converter. All of the code needed to support these boards is in arduino-common.

- blacklist arduino-uno and arduino-duemilanove for coap, libfixmath_unittests, lwip, nhdp, pthread, pthread_barrier, pthread_cleanup, pthread_condition_variable pthread_cooperation, pthread_rwlock and pthread_tls tests. - fix sys/pipe build - unittests: boards added to BOARD_INSUFICIENT_MEMORY list.

mali · 2016-09-21T19:57:50Z

New failures comes from #5763 merge

mali

@kYc0o or @LudwigKnuepfer I would like your opinion on this change related to PR5763

aabadie · 2016-09-21T21:24:05Z

Sorry @mali, I missed your previous comment. And looking at #5763, I think this PR is now potentially broken because of this line.
You now need to add something similar to this in board.h for arduino-uno/duemilanove if I understand well.

aabadie · 2016-09-21T21:28:25Z

Sorry again, @mali. You already backported the change and fixed the failing CI ! Great :)
I'll try again this branch tomorrow.

mali · 2016-09-22T07:14:53Z

@aabadie , I had this in queue in another branch ;-)

aabadie · 2016-09-22T07:29:28Z

Just tested it with some examples and tests. It works.

ACK and go !

kaspar030 added the Type: new feature The issue requests / The PR implemements a new feature for RIOT label May 18, 2016

kaspar030 reviewed May 18, 2016
View reviewed changes

OlegHahm added the Platform: AVR Platform: This PR/issue effects AVR-based platforms label May 18, 2016

OlegHahm assigned aabadie May 18, 2016

aabadie reviewed May 19, 2016
View reviewed changes

kYc0o added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label May 20, 2016

mali force-pushed the uno branch from 2384afe to e9f8df8 Compare May 20, 2016 21:18

mali force-pushed the uno branch from af628d6 to e1a317f Compare May 25, 2016 19:53

kYc0o added this to the Release 2016.07 milestone May 30, 2016

kaspar030 mentioned this pull request May 31, 2016

sys: make xtimer isr-safe #5428

Closed

kYc0o added the State: waiting for other PR State: The PR requires another PR to be merged first label Jun 7, 2016

PeterKietzmann mentioned this pull request Jun 21, 2016

cpu/atmega*: unify common code for atmega CPUs #5529

Merged

mali force-pushed the uno branch from 0a0187d to 65d8174 Compare June 27, 2016 19:37

cpu/atmega328p: add atmega328p mcu support

3f0e186

add atmega328p support with: uart, timer, spi and gpio

mali force-pushed the uno branch from 53109c8 to dd459f4 Compare September 5, 2016 19:07

mali changed the title ~~boards/arduino-uno : add basic support~~ boards: add arduino uno and duemilanove support Sep 5, 2016

mali force-pushed the uno branch from 822b9de to 18894a3 Compare September 19, 2016 20:04

aabadie requested changes Sep 20, 2016

View reviewed changes

mali force-pushed the uno branch from 02297f5 to 1e3a8b3 Compare September 20, 2016 18:45

aabadie requested changes Sep 21, 2016

View reviewed changes

mali force-pushed the uno branch from e4c34cf to 3ff576e Compare September 21, 2016 19:06

mali added 2 commits September 21, 2016 21:11

mali force-pushed the uno branch from ea41533 to 5b8cfb0 Compare September 21, 2016 20:32

boards/arduino-common: use software interrupt for context swap

5b8cfb0

mali commented Sep 21, 2016

View reviewed changes

aabadie approved these changes Sep 21, 2016

View reviewed changes

aabadie merged commit b2b42c7 into RIOT-OS:master Sep 22, 2016

mali deleted the uno branch September 22, 2016 18:42

Conversation

mali commented May 18, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aabadie commented May 19, 2016

Uh oh!

miri64 commented May 19, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mali commented May 20, 2016

Uh oh!

kYc0o commented May 21, 2016

Uh oh!

mali commented May 21, 2016

Uh oh!

mali commented May 25, 2016

Uh oh!

mali commented Jun 2, 2016

Uh oh!

kYc0o commented Jun 7, 2016

Uh oh!

PeterKietzmann commented Jun 22, 2016

Uh oh!

mali commented Jun 22, 2016

Uh oh!

PeterKietzmann commented Jun 23, 2016

Uh oh!

mali commented Jun 23, 2016

Uh oh!

kYc0o commented Jun 29, 2016

Uh oh!

mali commented Sep 5, 2016

Uh oh!

mali commented Sep 10, 2016

Uh oh!

mali commented Sep 19, 2016

Uh oh!

aabadie commented Sep 19, 2016

Uh oh!

aabadie commented Sep 19, 2016

Uh oh!

aabadie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mali commented Sep 20, 2016

Uh oh!

aabadie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mali commented Sep 21, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mali left a comment

Choose a reason for hiding this comment

Uh oh!

aabadie commented Sep 21, 2016

Uh oh!

aabadie commented Sep 21, 2016

Uh oh!

mali commented Sep 22, 2016

Uh oh!

mali commented May 18, 2016 •

edited

Loading

mali commented Sep 21, 2016 •

edited

Loading