Skip to content

net: introduce netstats#5176

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
OlegHahm:netstats_only
Mar 26, 2016
Merged

net: introduce netstats#5176
miri64 merged 1 commit intoRIOT-OS:masterfrom
OlegHahm:netstats_only

Conversation

@OlegHahm
Copy link
Copy Markdown
Member

@OlegHahm OlegHahm commented Mar 25, 2016

This is extracted from #4801 and introduces only the netstats struct and the corresponding netoption.

@OlegHahm OlegHahm added Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT labels Mar 25, 2016
@OlegHahm OlegHahm added this to the Release 2016.04 milestone Mar 25, 2016
@OlegHahm OlegHahm mentioned this pull request Mar 25, 2016
Merged
kaspar030
kaspar030 reviewed Mar 25, 2016
View reviewed changes
drivers/include/net/netdev2.h Outdated
*/
int (*set)(netdev2_t *dev, netopt_t opt,
void *value, size_t value_len);

Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 Mar 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, lets move this change into a follow-up PR.

Copy link
Copy Markdown
Member Author

@OlegHahm OlegHahm Mar 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was not even intended.

@OlegHahm OlegHahm added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Mar 25, 2016
@OlegHahm
Copy link
Copy Markdown
Member Author

OlegHahm commented Mar 25, 2016

Addressed comments. @kaspar030 do you like the updated description for the NETOPT_STATS?

kaspar030
kaspar030 reviewed Mar 25, 2016
View reviewed changes
sys/include/net/netstats.h Outdated
/**
* @defgroup net_netstats Packet statistics per layer
* @ingroup net
* @brief Each layer may store information about sent and received packets
Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 Mar 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two more times "device or protocol"?

@OlegHahm
Copy link
Copy Markdown
Member Author

OlegHahm commented Mar 25, 2016

Okay with this version of the netstats documentation? I think the netstats struct itself is actually agnostic if it is used for a device, a protocol, a layer or whatever else.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Mar 25, 2016

Please squash

@OlegHahm OlegHahm removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Mar 25, 2016
@OlegHahm
Copy link
Copy Markdown
Member Author

OlegHahm commented Mar 25, 2016

Squashed.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 25, 2016
@miri64
Copy link
Copy Markdown
Member

miri64 commented Mar 25, 2016

I guess the unittests need some adaption

@OlegHahm
Copy link
Copy Markdown
Member Author

OlegHahm commented Mar 25, 2016

Actually, just the string representation for the new NETOPT_STATS was missing.

@OlegHahm OlegHahm added CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 25, 2016
@miri64
Copy link
Copy Markdown
Member

miri64 commented Mar 25, 2016

I'm fine with the last change. ACK. Please squash.

@OlegHahm OlegHahm added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable labels Mar 25, 2016
@OlegHahm
Copy link
Copy Markdown
Member Author

OlegHahm commented Mar 25, 2016

Squashed - @kaspar030 are you fine, too?

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 25, 2016
@miri64
Copy link
Copy Markdown
Member

miri64 commented Mar 26, 2016

If @kaspar030 isn't fine with the current state he can provide a PR to fix it IMHO ;-) Go!

@miri64 miri64 merged commit 6aacfa8 into RIOT-OS:master Mar 26, 2016
@OlegHahm OlegHahm deleted the netstats_only branch March 26, 2016 10:47
@OlegHahm
Copy link
Copy Markdown
Member Author

OlegHahm commented Mar 26, 2016

IMO it wasn't that urgent, but anyway...

@OlegHahm OlegHahm mentioned this pull request Apr 13, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@miri64 miri64

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2016.04

Development

Successfully merging this pull request may close these issues.

3 participants

@OlegHahm @miri64 @kaspar030