gnrc_netdev2: do not override res for for ieee802154#5096
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Mar 17, 2016
Merged
gnrc_netdev2: do not override res for for ieee802154#5096miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64 merged 1 commit intoRIOT-OS:masterfrom
Conversation
`res` is used to set the frame header iovec's length afterwards so overriding it with a negative number is kind of a bad idea ;-).
miri64
added
Type: bug
miri64
added
the
CI: ready for build
| @@ -201,6 +200,9 @@ static int _send(gnrc_netdev2_t *gnrc_netdev2, gnrc_pktsnip_t *pkt) | |||
| vector[0].iov_len = (size_t)res; | |||
Member
Author
There was a problem hiding this comment.
This is the line I'm talking about in the description ;-)
Contributor
|
Got it, will test again~ :-) |
Contributor
|
Tested and ACK. |
Contributor
|
Bug fixed, it is now normal for sending packets. |
miri64
added a commit
that referenced
this pull request
Mar 17, 2016
…x/dont-override-len gnrc_netdev2: do not override res for for ieee802154
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resis used to set the frame header iovec's length afterwards so overriding it with a negative number is kind of a bad idea ;-).Provides fix for #4646 (comment) when merged into #4646.