cpu/make: added global Makefile.periph by haukepetersen · Pull Request #5065 · RIOT-OS/RIOT

haukepetersen · 2016-03-14T20:42:33Z

So far, every c file in RIOTBASE/CPU/periph/*.c is build. This leads to some not very nice use of file guards around full c files.

This PR improves the situation, as now only the peripherals, that are configured by the board (using the FEATURES_PROVIDED var) are actually compiled. This prevents us from having to configure certain peripherals for each board that uses a certain CPU, and from using those anti-pattern file guards.

This PR is a somewhat simplified and limited version of #3420.

jnohlgard · 2016-03-15T09:57:07Z

What do you think about using the wildcard Makefile function in another way?

# get a list with the peripherals, that are configured by the board
WANT = $(patsubst periph_%,%*.c,$(filter periph_%,$(FEATURES_PROVIDED)))
# only compile the peripheral drivers, that are present and configured
SRC += $(wildcard $(WANT))

This would make a list of all wanted periph drivers just as before, but matching filenames against a wildcard pattern instead.
That would cover the kinetis hwrng special case as well.

FEATURES_PROVIDED=periph_uart periph_gpio periph_hwrng
would translate into:
SRC += $(wildcard uart*.c gpio*.c hwrng*.c)

haukepetersen · 2016-03-15T10:06:02Z

That would do, but I think it defeats the purpose. Let's take the hwrng issue for the kinetis: I think the goal here is actually not to build all hwrng_*.c files, but in the mit-term to only build the one specific file that is actually wanted. This way we can get rid of the #ifdef KINETIS_RNGA guards all together.

haukepetersen · 2016-03-18T09:35:25Z

@gebart ping

jnohlgard · 2016-03-18T12:46:42Z

I don't have any good ideas for the hwrng_* files on Kinetis... I propose we merge this as-is and open an issue for getting rid of the whole-file ifdefs as a reminder. What do you think?

haukepetersen · 2016-03-18T13:50:28Z

Sounds good to me.

jnohlgard · 2016-03-19T16:56:07Z

something is messed up, see CI logs, lots of periph tests are failing.

haukepetersen · 2016-03-21T10:11:35Z

I had this once before locally (but I can not explain it): it seems to me the Makefile.buildtest fucks up, it tries to build tests for boards, that do not provide the required features (e.g. CPUID for avsextrem). I failed more than once before in understanding and adapting the Makefile.buildtest, so no idea how to fix this.

haukepetersen · 2016-03-21T10:12:21Z

Also I have no idea why this behavior is caused by this PR, where it should actually be quite unrelated?!

haukepetersen · 2016-03-21T15:03:32Z

Just out of curiosity: restarted the build-test to see if the result is reproducible.

haukepetersen · 2016-03-21T15:23:04Z

I think I found the reason: by exporting the FEATURES_PROVIDED variable in Makefile.vars we somehow break the Makefile.buildtest. But this file I tried to understand 100 times and always failed...

@Kijewski: can you help out here and tell me out to make this work?

haukepetersen · 2016-03-29T10:22:17Z

won't make it for this release, so postponing it.

jnohlgard · 2016-07-12T08:45:26Z

I guess we can postpone this another release

haukepetersen · 2017-03-22T10:38:42Z

tried another path, but still not working. @kaspar030 feel free to take over...

aabadie · 2017-04-06T07:36:36Z

Needs rebase since #4699 was merged.

haukepetersen · 2017-04-06T08:21:37Z

I won't - as stated above, I can't find a solution that works to this topic, so others need to take over...

PeterKietzmann · 2017-04-07T12:23:01Z

Let's close it as nobody is working on it?

aabadie · 2017-06-20T18:56:41Z

ping what should we do here ?

haukepetersen · 2017-06-26T08:53:05Z

Thats the question :-)

This topic is getting more and more pressing and needs to be solved ASAP with high priority, but for this somebody needs an idea how to do this... So would like to leave the PR open until something new is PRed so we keep this on our minds.

haukepetersen · 2017-09-08T09:31:53Z

This PR is superseded by #7241. But I leave it open for now as this PR contains some changes that need to be moved into #7241...

haukepetersen · 2017-10-04T09:47:54Z

closed in favor of #7241

haukepetersen added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: build system Area: Build system Impact: major The PR changes a significant part of the code base. It should be reviewed carefully labels Mar 14, 2016

haukepetersen assigned jnohlgard Mar 14, 2016

haukepetersen added this to the Release 2016.04 milestone Mar 14, 2016

haukepetersen added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 14, 2016

haukepetersen mentioned this pull request Mar 15, 2016

cpu/stm32f1/periph/dac: DAC implementation for STM32F1 #4225

Merged

haukepetersen added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 15, 2016

OlegHahm modified the milestone: Release 2016.04 Mar 17, 2016

jnohlgard added this to the Release 2016.04 milestone Mar 18, 2016

haukepetersen added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 21, 2016

haukepetersen mentioned this pull request Mar 22, 2016

make: buildtest breaks when exporting FEATURES_PROVIDED var #5128

Closed

haukepetersen modified the milestones: Release 2016.07, Release 2016.04 Mar 29, 2016

jnohlgard added this to the Release 2016.10 milestone Jul 12, 2016

haukepetersen added 7 commits March 22, 2017 09:41

make/Makefile.dep: added uart dependency

a503579

drivers/Makefile.dep: added missing requirements

c34eea3

cpu: use Makefile.periph for all CPUs

38c2cae

cpu: added missing periph deps

c440a03

boards/f4vi1: added missing features

6204150

boards: added missing feature requirements

f4db454

WIP

56a08f1

haukepetersen force-pushed the opt_periph_makimaki branch from 223b0bb to 56a08f1 Compare March 22, 2017 10:38

haukepetersen added State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 22, 2017

miri64 assigned aabadie Apr 6, 2017

kaspar030 modified the milestones: Release 2017.04, Release 2017.07 Apr 21, 2017

haukepetersen mentioned this pull request Apr 24, 2017

periph/rtc: move init from auto_init to periph_init #6900

Merged

aabadie modified the milestones: Release 2017.07, Release 2017.10 Jun 30, 2017

kaspar030 mentioned this pull request Sep 9, 2017

make: use submodules for periph #7241

Merged

haukepetersen closed this Oct 4, 2017

Conversation

haukepetersen commented Mar 14, 2016

Uh oh!

jnohlgard commented Mar 15, 2016

Uh oh!

haukepetersen commented Mar 15, 2016

Uh oh!

haukepetersen commented Mar 18, 2016

Uh oh!

jnohlgard commented Mar 18, 2016

Uh oh!

haukepetersen commented Mar 18, 2016

Uh oh!

jnohlgard commented Mar 19, 2016

Uh oh!

haukepetersen commented Mar 21, 2016

Uh oh!

haukepetersen commented Mar 21, 2016

Uh oh!

haukepetersen commented Mar 21, 2016

Uh oh!

haukepetersen commented Mar 21, 2016

Uh oh!

haukepetersen commented Mar 29, 2016

Uh oh!

jnohlgard commented Jul 12, 2016

Uh oh!

haukepetersen commented Mar 22, 2017

Uh oh!

aabadie commented Apr 6, 2017

Uh oh!

haukepetersen commented Apr 6, 2017

Uh oh!

PeterKietzmann commented Apr 7, 2017

Uh oh!

aabadie commented Jun 20, 2017

Uh oh!

haukepetersen commented Jun 26, 2017

Uh oh!

haukepetersen commented Sep 8, 2017

Uh oh!

haukepetersen commented Oct 4, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants