cpu/atmega2560: reworked UART driver#5026
Closed
haukepetersen wants to merge 4 commits intoRIOT-OS:masterfrom
Closed
cpu/atmega2560: reworked UART driver#5026haukepetersen wants to merge 4 commits intoRIOT-OS:masterfrom
haukepetersen wants to merge 4 commits intoRIOT-OS:masterfrom
Conversation
haukepetersen
added
Type: enhancement
| #define MEGA_UART1_BASE (uint16_t *)(&UCSR1A) | ||
| #define MEGA_UART2_BASE (uint16_t *)(&UCSR2A) | ||
| #define MEGA_UART3_BASE (uint16_t *)(&UCSR2A) | ||
| /** @} */ |
Contributor
There was a problem hiding this comment.
No extra parentheses required here?
Contributor
Author
There was a problem hiding this comment.
no really, but they won't hurt either -> will fix
Contributor
|
can you rebase since #5014 was merged? :) |
Contributor
Author
|
yepp |
haukepetersen
force-pushed
the
opt_atmega_uart2
branch
from
107f304 to
71e8cec
Compare
Contributor
Author
|
rebased |
haukepetersen
force-pushed
the
opt_atmega_uart2
branch
from
71e8cec to
7741acc
Compare
Contributor
Author
|
also added the missing parens |
Contributor
|
great thanks |
Contributor
|
is this normal?: |
Contributor
|
I'm trying to use tests/periph_uart and it freezes. After a reboot it prints trash, lots of trash :S |
Contributor
|
actually it is possible to initialise one UART but at the second one it freezes |
Contributor
Author
|
still looking into this, but won't probably make it for the release, so putting this on the list for the next one... |
Contributor
|
seems reasonable :) |
This was referenced Jun 7, 2016
kYc0o
added a commit
that referenced
this pull request
Jun 19, 2016
cpu/atmega2560: reworked UART (from #5026)
Member
|
#5537 was merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gets rid of unneccesary configuration stuff in the boards periph_conf, makes the UART configuration much easier and saves ~650 byte flash for the default example