Skip to content

drivers: netdev2: remove netdev2 event_callback isr_arg#4871

Merged
miri64 merged 6 commits intoRIOT-OS:masterfrom
kaspar030:remove_netdev2_isr_arg
Jun 2, 2016
Merged

drivers: netdev2: remove netdev2 event_callback isr_arg#4871
miri64 merged 6 commits intoRIOT-OS:masterfrom
kaspar030:remove_netdev2_isr_arg

Conversation

@kaspar030
Copy link
Copy Markdown
Contributor

@kaspar030 kaspar030 commented Feb 21, 2016

See #4864.

This PR removes event_callback's extra argument, as it is currently completely unused.

PR marked WIP as I didn't test yet, let's discuss first if we need the argument.

@kaspar030 kaspar030 added Area: network Area: Networking State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Area: drivers Area: Device drivers labels Feb 21, 2016
@kaspar030 kaspar030 mentioned this pull request Feb 21, 2016
Merged
@miri64
Copy link
Copy Markdown
Member

miri64 commented Feb 21, 2016

As stated in #4864 (comment): I would prefer to change the name of the netdev2_t member then also. With this change the name doesn't make much sense.

@kaspar030
Copy link
Copy Markdown
Contributor Author

kaspar030 commented Feb 21, 2016

@authmillenon I got a commit somewhere, sec...

miri64
miri64 reviewed Feb 22, 2016
View reviewed changes
drivers/include/net/netdev2.h
const struct netdev2_driver *driver; /**< ptr to that driver's interface. */
netdev2_event_cb_t event_callback; /**< callback for device events */
void* isr_arg; /**< argument to pass on isr event */
void* context; /**< ptr to network stack context */
Copy link
Copy Markdown
Member

@miri64 miri64 Feb 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If your at it: fix the spaces ;)

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Feb 22, 2016

Seems like the right way to go to me.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Mar 16, 2016

Needs rebase (but I would actually prefer to wait for it until #4646 was merged).

@miri64 miri64 added this to the Release 2016.07 milestone Mar 23, 2016
@miri64
Copy link
Copy Markdown
Member

miri64 commented Apr 26, 2016

Still needs rebase (#4646 was rebased a while back).

@kaspar030 kaspar030 force-pushed the remove_netdev2_isr_arg branch from 9c2a95a to 79258e7 Compare May 31, 2016 19:41
@kaspar030
Copy link
Copy Markdown
Contributor Author

kaspar030 commented May 31, 2016

  • rebased

@kaspar030 kaspar030 removed the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label May 31, 2016
@miri64
Copy link
Copy Markdown
Member

miri64 commented May 31, 2016

https://github.com/RIOT-OS/RIOT/pull/4871/files#diff-d6f865662e9a41135b416f0ac6f28660R300

@miri64
Copy link
Copy Markdown
Member

miri64 commented May 31, 2016

Other than that it seems to work.

@kaspar030 kaspar030 force-pushed the remove_netdev2_isr_arg branch from 79258e7 to ad8492a Compare May 31, 2016 20:07
@kaspar030
Copy link
Copy Markdown
Contributor Author

kaspar030 commented May 31, 2016

found another one in lwip.

@kaspar030 kaspar030 removed the Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR label May 31, 2016
@kaspar030
Copy link
Copy Markdown
Contributor Author

kaspar030 commented Jun 1, 2016

launching CI to check for build errors...

@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 1, 2016
@miri64
Copy link
Copy Markdown
Member

miri64 commented Jun 2, 2016

Sorry somehow forgot about this one -.-

@miri64
Copy link
Copy Markdown
Member

miri64 commented Jun 2, 2016

There are still errors regarding the types of event callbacks.

@kaspar030 kaspar030 force-pushed the remove_netdev2_isr_arg branch from 7f10187 to 15d9ce4 Compare June 2, 2016 09:12
@kaspar030
Copy link
Copy Markdown
Contributor Author

kaspar030 commented Jun 2, 2016

@miri64 murdock is happy. did you ack?

@miri64
Copy link
Copy Markdown
Member

miri64 commented Jun 2, 2016

Networking still works for at86rf2xx based boards and native so I say ACK and go.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Jun 2, 2016

Ah wait, let me give emb6 and lwIP a quick test

@miri64
Copy link
Copy Markdown
Member

miri64 commented Jun 2, 2016

🗹 lwIP

@miri64
Copy link
Copy Markdown
Member

miri64 commented Jun 2, 2016

🗹 emb6 and go.

@miri64 miri64 merged commit 35077bb into RIOT-OS:master Jun 2, 2016
@kaspar030 kaspar030 deleted the remove_netdev2_isr_arg branch June 2, 2016 11:34
This was referenced Jun 2, 2016
Merged
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@miri64 miri64

Labels

Area: drivers Area: Device drivers Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaspar030 @miri64 @OlegHahm