Skip to content

netstats: introduce L2 netstats#4801

Merged
OlegHahm merged 4 commits intoRIOT-OS:masterfrom
OlegHahm:netstats
Mar 30, 2016
Merged

netstats: introduce L2 netstats#4801
OlegHahm merged 4 commits intoRIOT-OS:masterfrom
OlegHahm:netstats

Conversation

@OlegHahm
Copy link
Copy Markdown
Member

@OlegHahm OlegHahm commented Feb 12, 2016

A first step towards addressing #1297.

Depends on #4645.

Waits for #5176, but is not yet rebased on it.

@OlegHahm OlegHahm added Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR labels Feb 12, 2016
@OlegHahm OlegHahm added the State: waiting for other PR State: The PR requires another PR to be merged first label Feb 12, 2016
@OlegHahm OlegHahm mentioned this pull request Feb 12, 2016
Closed
@miri64
Copy link
Copy Markdown
Member

miri64 commented Feb 12, 2016

Sorry, I know you already took this out of #4795, but could you maybe make an independent PR, that only introduces netstat and then provide the adaptations to the existing netdev2, so the introduction PR is not dependent on my PRs (and resulting from that easier and faster to review)?

@OlegHahm
Copy link
Copy Markdown
Member Author

OlegHahm commented Feb 19, 2016

For the record, I'm working on an revised version that's completely independent from other PRs, but includes stats for link and network layer. Stay tuned.

@OlegHahm OlegHahm added State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Feb 19, 2016
@OlegHahm OlegHahm added this to the Release 2016.03 milestone Feb 24, 2016
@OlegHahm OlegHahm added CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable and removed State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels Mar 24, 2016
@OlegHahm
Copy link
Copy Markdown
Member Author

OlegHahm commented Mar 24, 2016

Rebased to master, ready for review. To test add USEMODULE += netstats to your network application and check with ifconfig.

miri64
miri64 reviewed Mar 24, 2016
View reviewed changes
sys/include/net/netopt.h

/**
* @brief get statistics about sent and received packets of the layer
*/
Copy link
Copy Markdown
Member

@miri64 miri64 Mar 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document the type needed for this option.

@OlegHahm OlegHahm mentioned this pull request Mar 25, 2016
Merged
@OlegHahm OlegHahm changed the title Introduce netstats netstats: introduce L2 netstats Mar 25, 2016
@OlegHahm OlegHahm added the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 25, 2016
@OlegHahm
Copy link
Copy Markdown
Member Author

OlegHahm commented Mar 25, 2016

Sorry, forgot about the discussion in #4801 (comment). Factored it out in #5176.

@OlegHahm OlegHahm force-pushed the netstats branch 2 times, most recently from ae39dd0 to bba5534 Compare March 25, 2016 15:08
@OlegHahm OlegHahm mentioned this pull request Mar 25, 2016
Merged
@OlegHahm OlegHahm removed the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 26, 2016
@OlegHahm
Copy link
Copy Markdown
Member Author

OlegHahm commented Mar 26, 2016

Rebased to current master.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Mar 29, 2016

ACK and go when Murdock is happy. Please squash

@OlegHahm OlegHahm added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable labels Mar 29, 2016
@OlegHahm
Copy link
Copy Markdown
Member Author

OlegHahm commented Mar 29, 2016

Squashed

@OlegHahm OlegHahm added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR labels Mar 30, 2016
@OlegHahm OlegHahm merged commit 1f4d73d into RIOT-OS:master Mar 30, 2016
@OlegHahm OlegHahm deleted the netstats branch March 30, 2016 12:42
@OlegHahm OlegHahm mentioned this pull request Apr 3, 2016
Merged
@haukepetersen haukepetersen mentioned this pull request Apr 13, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@miri64 miri64

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2016.04

Development

Successfully merging this pull request may close these issues.

3 participants

@OlegHahm @miri64 @emmanuelsearch