Skip to content

sys: net: gnrc: prefer prefix list over fib#4730

Closed
kaspar030 wants to merge 1 commit intoRIOT-OS:masterfrom
kaspar030:prefer_prefix_list_over_fib
Closed

sys: net: gnrc: prefer prefix list over fib#4730
kaspar030 wants to merge 1 commit intoRIOT-OS:masterfrom
kaspar030:prefer_prefix_list_over_fib

Conversation

@kaspar030
Copy link
Copy Markdown
Contributor

Currently, an entry in the fib (e.g., default route) is preferred over an entry in the prefix list.
This patch skips fib lookup if an entry in the prefix list exists.

(It is possible that the fib contains a matching entry with prefix length > 64. That would be skipped using this PR. But as that is a far more specific use case than a default route entry in the fib, I propose merging this and fixing lookup later.)

@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking labels Feb 2, 2016
@miri64
Copy link
Copy Markdown
Member

miri64 commented Feb 2, 2016

How do you get the next hop from this scenario?

@kaspar030
Copy link
Copy Markdown
Contributor Author

Doesn't the neighbor cache lookup trigger neighbor solicitations? If not, this patch just worked for me because the involved address were already in the cache...
If yes, the next hop is the target (as that prefix is configured to be reachable on that interface), and NDP will yield the next-hop l2.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Feb 2, 2016

Doesn't the neighbor cache lookup trigger neighbor solicitations? If not, this patch just worked for me because the involved address were already in the cache...

Technically wrong, but the result is the same: on 6LoWPAN there is no solicitation on address resolution; an address needs to be registered to the upstream router on addition to the interface. But, the WPAN is a mesh, so just because the prefix of the destination address is beyond one interface it does not need to be the next hop (so I guess the matching for prefixes >64 from the FIB is vital for the working of a 6LoWPAN).

@kaspar030
Copy link
Copy Markdown
Contributor Author

But, the WPAN is a mesh, so just because the prefix of the destination address is beyond one interface it does not need to be the next hop (so I guess the matching for prefixes >64 from the FIB is vital for the working of a 6LoWPAN).

Is 6lowpan putting entries in the fib?

@miri64
Copy link
Copy Markdown
Member

miri64 commented Feb 2, 2016

No, that is RPL's task.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Feb 2, 2016

BTW have you activated RPL on your border-router example?

@kaspar030
Copy link
Copy Markdown
Contributor Author

No RPL enabled.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Feb 9, 2016

Please rebase

@kaspar030 kaspar030 force-pushed the prefer_prefix_list_over_fib branch from 2008500 to 3fdfa94 Compare February 9, 2016 10:12
@kaspar030
Copy link
Copy Markdown
Contributor Author

  • rebased

@miri64
Copy link
Copy Markdown
Member

miri64 commented Feb 9, 2016

How can I test this BTW?

@kaspar030
Copy link
Copy Markdown
Contributor Author

How can I test this BTW?

add prefix (e.g., 2001:db8::/64) to 6lo interface, ping that address from different interface, e.g., slip or ethos.

@miri64
Copy link
Copy Markdown
Member

miri64 commented Feb 9, 2016

But how is this behavior different from #4738?

@miri64
Copy link
Copy Markdown
Member

miri64 commented Feb 9, 2016

(except that this change only works for 6Lo)

@miri64
Copy link
Copy Markdown
Member

miri64 commented Mar 6, 2016

@kaspar030 ping?

@miri64
Copy link
Copy Markdown
Member

miri64 commented Mar 6, 2016

Since you are endorsing #4738: can we close this PR?

@miri64 miri64 modified the milestone: Release 2016.07 Mar 29, 2016
@kaspar030
Copy link
Copy Markdown
Contributor Author

Since you are endorsing #4738: can we close this PR?

yes.

@kaspar030 kaspar030 closed this Mar 30, 2016
@kaspar030 kaspar030 deleted the prefer_prefix_list_over_fib branch March 30, 2016 10:36
@OlegHahm OlegHahm modified the milestones: Release 2016.04, Release 2016.07 Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants