6lo nd: prefer NCEs over FIB entries#4714
Conversation
If an address can be found in the neighbor cache, it should be used - whatever the FIB may return.
New condition -> new line
|
I'm ambivalent about this. On the first hand the NC has much better information on the node's neighbors on the other we take out user control over forwarding with this... |
|
Well, first of all, the current behavior is broken. (A node with more than one interfaces may have a route in its FIB that matches the destination, e.g., the default route which may return another interface than the one stored in the NC, resulting in not sending the packet.) @emmanuelsearch, @cgundogan, @Yonezawa-T2, any opinon? |
|
The current implementation already prefers NC over FIB, except interface. The outline of the current
This patch changes step 2 and 3 to follows: 2 . Lookup NC with the destination address and the original interface. and add the following between 3 and 4: 3.1. Lookup NC with the destination address and the interface of the next hop (if any). I agree with @OlegHahm, looking up NC with the destination address and the interface of the next hop seems make no sense. |
|
@Yonezawa-T2, thanks for the clarification. |
|
So, can we finally merge this? |
|
I'm not sure how to test this, but at least networking through a border router works for both master and this PR. (Untested) ACK. |
|
Tested, @kaspar030 confirmed. Go. |
6lo nd: prefer NCEs over FIB entries
If an address can be found in the neighbor cache, it should be used - whatever the FIB may return.