netdev2: remove const modifier from vector in send method#4678
Closed
miri64 wants to merge 1 commit intoRIOT-OS:masterfrom
Closed
netdev2: remove const modifier from vector in send method#4678miri64 wants to merge 1 commit intoRIOT-OS:masterfrom
miri64 wants to merge 1 commit intoRIOT-OS:masterfrom
Conversation
miri64
added
Discussion: RFC
miri64
added
the
CI: ready for build
Contributor
|
Not sure I agree, why shouldn't the 802.15.4 intermediate layer not be able to store sequence numbers? |
Member
Author
|
You mean introduce a new type for that? Sure, for the given case this might be a solution, but I'm still not quite sure if we put to much restrictions with the cons modifier on the API. I can think of a bunch of reasons to change the contents of vector in send. Changing to a different format as XBee does e. g. |
haukepetersen
removed
the
Community: Hack'n'ACK candidate
Member
Author
|
Closed because I will overhaul the intermediate layer this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
constmodifier hurts in this instance more than it does good IMHO. There might be a need to change parts of the vector. E.g. sequence numbers of frame headers are better updated in the send method, since the actual device type can store the current sequence number, whilenetdev2_tdoesn't.