core: rename tcb_t -> thread_t, move into thread.h by kaspar030 · Pull Request #4578 · RIOT-OS/RIOT

kaspar030 · 2016-01-05T13:22:37Z

Calling the struct "thread control block" seems outdated. This PR moves the definition into thread.h.

haukepetersen · 2016-01-05T13:30:45Z

I like!

Kijewski · 2016-01-05T13:33:13Z

👍

DipSwitch · 2016-01-05T19:28:26Z

1ste ACK in tha pocket

haukepetersen · 2016-01-12T15:32:23Z

2nd ACK (once Travis is happy)

miri64 · 2016-01-12T16:12:21Z

core/include/thread.h

Sorry for just writing that now, but wouldn't a THREAD_ prefix on those be more in line with the coding conventions?

I think that's out of scope for this PR.

kaspar030 · 2016-01-14T22:29:51Z

Well, travis did not agree at all. ;)

factored out thread stacksize defines into "cpu_conf_common.h" for all cortex-M cpu's
fixed some includes

@DipSwitch @haukepetersen pls take another look...

kaspar030 · 2016-01-15T11:00:39Z

Sorry, there's more trouble.

DipSwitch · 2016-02-03T23:16:02Z

core/include/thread.h

Maybe the comment alignment should be fixed?

DipSwitch · 2016-02-03T23:22:23Z

Just a few comment alignment stuff, not that it must be fixed by me. But it would look better ;)

The code seems fine, ACK

OlegHahm · 2016-02-22T22:15:17Z

What's up with this PR?

kaspar030 · 2016-02-22T22:31:41Z

I've rebased it yesterday and (hopefully) just fixed the last compile problem.

I'll unmark it WIP.
Someone should take a look at the new cpu_cortex_common.h, I had to change the include order slightly. @haukepetersen ?

haukepetersen · 2016-03-01T15:25:09Z

please reomve the stack size defines from the cortexm_common/include/cpu.h, otherwise they are twice defined for cortex MCUs...

haukepetersen · 2016-03-01T15:25:36Z

otherwise looks good, please squash!

kaspar030 · 2016-03-01T15:38:43Z

addressed, squashed

kaspar030 · 2016-03-05T17:23:00Z

removed riot ci dependencies

kaspar030 · 2016-03-05T20:15:38Z

Bascally three ACKs -> go!

core: rename tcb_t -> thread_t, move into thread.h

kaspar030 added Area: core Area: RIOT kernel. Handle PRs marked with this with care! Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Jan 5, 2016

kaspar030 assigned haukepetersen Jan 5, 2016

miri64 reviewed Jan 12, 2016
View reviewed changes

OlegHahm added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 12, 2016

kaspar030 added this to the Release 2016.03 milestone Jan 14, 2016

kaspar030 added the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Jan 15, 2016

DipSwitch reviewed Feb 3, 2016
View reviewed changes

core/include/thread.h Outdated

Copy link
Copy Markdown

Member

DipSwitch Feb 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the comment alignment should be fixed?

kaspar030 force-pushed the refactor_tcb_into_thread branch from 6fc2941 to 4cbe9e8 Compare February 22, 2016 00:12

OlegHahm added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Feb 22, 2016

kaspar030 removed the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Feb 22, 2016

OlegHahm added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Feb 27, 2016

kaspar030 force-pushed the refactor_tcb_into_thread branch 2 times, most recently from 9c5380a to 06a9efc Compare February 29, 2016 23:15

kaspar030 force-pushed the refactor_tcb_into_thread branch from 06a9efc to 5dbacf0 Compare March 1, 2016 15:37

haukepetersen removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Mar 1, 2016

kaspar030 added 8 commits March 5, 2016 18:20

core: rename tcb_t -> thread_t, move into thread.h

2b010b5

cpu: cortexm*: move cpu_conf.h stuff from cpu.h into cpu_conf_common.h

6881f65

sys: newlib: include fix

67d3d44

sys: cpp11-compat: adapt to thread.h

0bf305e

sys: posix: posix_semaphore: adapt to thread.h

c3fe461

cpu: msp430: adapt to thread.h

a7adbac

cpu: atmega2560: timer: adapt to thread.h

142bbef

cpu: lpc11u34: gpio: adapt to thread.h

ed03204

kaspar030 force-pushed the refactor_tcb_into_thread branch from 90358e3 to ed03204 Compare March 5, 2016 17:22

kaspar030 added a commit that referenced this pull request Mar 5, 2016

Merge pull request #4578 from kaspar030/refactor_tcb_into_thread

910290c

core: rename tcb_t -> thread_t, move into thread.h

kaspar030 merged commit 910290c into RIOT-OS:master Mar 5, 2016

kaspar030 deleted the refactor_tcb_into_thread branch March 5, 2016 20:15

Yonezawa-T2 mentioned this pull request Mar 7, 2016

thread_t is already defined by OS X #4973

Closed

jnohlgard mentioned this pull request Mar 10, 2016

cortex_m: Add debug symbols for OpenOCD/GDB thread support #4058

Merged

Conversation

kaspar030 commented Jan 5, 2016

Uh oh!

haukepetersen commented Jan 5, 2016

Uh oh!

Kijewski commented Jan 5, 2016

Uh oh!

DipSwitch commented Jan 5, 2016

Uh oh!

haukepetersen commented Jan 12, 2016

Uh oh!

miri64 Jan 12, 2016

Choose a reason for hiding this comment

Uh oh!

OlegHahm Jan 12, 2016

Choose a reason for hiding this comment

Uh oh!

kaspar030 commented Jan 14, 2016

Uh oh!

kaspar030 commented Jan 15, 2016

Uh oh!

DipSwitch Feb 3, 2016

Choose a reason for hiding this comment

Uh oh!

DipSwitch commented Feb 3, 2016

Uh oh!

OlegHahm commented Feb 22, 2016

Uh oh!

kaspar030 commented Feb 22, 2016

Uh oh!

haukepetersen commented Mar 1, 2016

Uh oh!

haukepetersen commented Mar 1, 2016

Uh oh!

kaspar030 commented Mar 1, 2016

Uh oh!

kaspar030 commented Mar 5, 2016

Uh oh!

kaspar030 commented Mar 5, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants