Skip to content

sema: some API fixes#4551

Merged
miri64 merged 3 commits intoRIOT-OS:masterfrom
miri64:sema/fix/post
Jan 26, 2016
Merged

sema: some API fixes#4551
miri64 merged 3 commits intoRIOT-OS:masterfrom
miri64:sema/fix/post

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Dec 27, 2015

  • fixes (and documents properly) return values of sema_post()
  • introduces static initializer for semaphores
  • some style fixes.

@miri64 miri64 added the Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. label Dec 27, 2015
@miri64 miri64 added this to the Release 2016.03 milestone Dec 27, 2015
@miri64 miri64 mentioned this pull request Dec 27, 2015
Closed
Kijewski
Kijewski reviewed Dec 28, 2015
View reviewed changes
sys/include/sema.h Outdated
Copy link
Copy Markdown
Contributor

@Kijewski Kijewski Dec 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(value)

Copy link
Copy Markdown
Member Author

@miri64 miri64 Dec 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@Kijewski
Copy link
Copy Markdown
Contributor

Kijewski commented Dec 28, 2015

Looks good, int sem_post(sem_t*) should not have worked correctly before.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jan 23, 2016

Was that an ACK, @Kijewski?

@miri64 miri64 added Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 23, 2016
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jan 23, 2016

Squashed and rebased to current master

@josephnoir
Copy link
Copy Markdown
Contributor

josephnoir commented Jan 26, 2016

Why does the semaphore use a volatile int instead of an atomic int, like the mutex implementation does?

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Jan 26, 2016

Because the core of this implementation is older than the current iteration of core_atomic. Will, but in another PR, since this is not related to the topic of this PR.

@miri64 miri64 mentioned this pull request Jan 26, 2016
Closed
@jfischer-no
Copy link
Copy Markdown
Contributor

jfischer-no commented Jan 26, 2016

ACK from my side

miri64 added a commit that referenced this pull request Jan 26, 2016
@miri64
Merge pull request #4551 from authmillenon/sema/fix/post
d38a9db 
sema: some API fixes
@miri64 miri64 merged commit d38a9db into RIOT-OS:master Jan 26, 2016
@miri64 miri64 deleted the sema/fix/post branch January 26, 2016 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jfischer-no jfischer-no

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care.

Projects

None yet

Milestone

Release 2016.04

Development

Successfully merging this pull request may close these issues.

4 participants

@miri64 @Kijewski @josephnoir @jfischer-no