drivers/periph: updated DAC driver interface#4431
Merged
DipSwitch merged 8 commits intoRIOT-OS:masterfrom Mar 15, 2016
Merged
Conversation
haukepetersen
added
Type: enhancement
This was referenced Dec 8, 2015
Contributor
Author
There was a problem hiding this comment.
nope! This is one of the ideas of the re-doing of periph interfaces to get rid of this anti-pattern. At least at some point the approach of #3420 will remove the need of these guards once and for all
DipSwitch
added a commit
to DipSwitch/RIOT
that referenced
this pull request
Dec 13, 2015
jnohlgard
pushed a commit
to jnohlgard/RIOT
that referenced
this pull request
Feb 14, 2016
sys/analog_util/dac_util.c
Outdated
|
|
||
| uint16_t dac_util_map(int value, int min, int max) | ||
| { | ||
| return (uint16_t)((value - min) * 0xffff) / (max - min); |
jnohlgard
added
State: waiting for other PR
Member
|
ACK for the change, let's wait for #4430 and then rebase. See my minor comments above though |
Closed
Member
|
Please rebase |
haukepetersen
force-pushed
the
opt_periph_dac
branch
from
c3a2c8f to
1dafea9
Compare
haukepetersen
removed
CI: needs squashing
haukepetersen
force-pushed
the
opt_periph_dac
branch
from
1dafea9 to
c8ef57b
Compare
Contributor
Author
|
addressed comments, rebased and sqashed. |
haukepetersen
added
the
CI: ready for build
Member
|
Double ACK, not that it's needed and go! |
DipSwitch
added a commit
that referenced
this pull request
Mar 15, 2016
drivers/periph: updated DAC driver interface
DipSwitch
added a commit
to DipSwitch/RIOT
that referenced
this pull request
Mar 15, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analog to #4430, here is also an adaption/simplification of the
DACdriver interface.It is rebased on #4430 - so currently both API updates are included in this PR...