Revert "stm32l1/i2c.c: adapt for new periph driver interface"#4428
Merged
OlegHahm merged 1 commit intoRIOT-OS:masterfrom Dec 8, 2015
Merged
Revert "stm32l1/i2c.c: adapt for new periph driver interface"#4428OlegHahm merged 1 commit intoRIOT-OS:masterfrom
OlegHahm merged 1 commit intoRIOT-OS:masterfrom
Conversation
This reverts commit e9215a6.
PeterKietzmann
added
Type: bug
PeterKietzmann
added
the
CI: ready for build
Member
|
ACK and go! |
OlegHahm
added a commit
that referenced
this pull request
Dec 8, 2015
Revert "stm32l1/i2c.c: adapt for new periph driver interface"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e9215a6.
It turned out that #4096 did not work correctly. The i2c driver can also be optimized by using the gpio API. Unluckily there is one feature missing for the usage in i2c: the possibility to configure outputs as open drain, as needed for i2c buses. I will discuss this offline and come along with a PR which recovers the wanted improvement of #4096 again then.