sema: pre-set timeout-timer for sema_wait_timed_msg()#4374
Merged
OlegHahm merged 2 commits intoRIOT-OS:masterfrom Jan 26, 2016
Merged
sema: pre-set timeout-timer for sema_wait_timed_msg()#4374OlegHahm merged 2 commits intoRIOT-OS:masterfrom
OlegHahm merged 2 commits intoRIOT-OS:masterfrom
Conversation
miri64
added
the
Type: bug
Member
|
Shouldn't this be fixed in xtimer instead? |
Member
Author
|
I don't know how :( |
miri64
force-pushed
the
sema/fix/timer-pre-set
branch
from
14e2007 to
47a2df7
Compare
miri64
added
Community: Hack'n'ACK candidate
Member
Author
|
In the long-run it is more correct to set this values anyway, I guess. |
Contributor
|
Initialization sounds like a good idea. The style guid doesn't say anything about multiple assignments in one line, is that generally accepted? |
Member
Author
|
If it doesn't say anything then it is accepted, I guess. |
Member
|
👍 for initialization, but xtimer should be fixed anyway. |
Member
Author
|
@OlegHahm I'm not sure this CAN be fixed. For all I now, these values might be legally set by some previous |
Contributor
|
👍 Looks straight forward. Can't say anything about the xtimer stuff. |
OlegHahm
added a commit
that referenced
this pull request
Jan 26, 2016
sema: pre-set timeout-timer for sema_wait_timed_msg()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work-around to prevent weird errors from happening due to #4372.