Skip to content

making include directives consistent#437

Merged
OlegHahm merged 2 commits intoRIOT-OS:masterfrom
OlegHahm:include_directives
Dec 19, 2013
Merged

making include directives consistent#437
OlegHahm merged 2 commits intoRIOT-OS:masterfrom
OlegHahm:include_directives

Conversation

@OlegHahm
Copy link
Copy Markdown
Member

@OlegHahm OlegHahm commented Dec 18, 2013

This PR replaces only " with <> and via versa in include directives. Hence, it's just cosmetic and fixes #12

@ghost ghost assigned BytesGalore Dec 18, 2013
@OlegHahm OlegHahm mentioned this pull request Dec 18, 2013
Merged
@LudwigKnuepfer
Copy link
Copy Markdown
Member

LudwigKnuepfer commented Dec 19, 2013

Breaks on telosb, needs rebase

@OlegHahm
Copy link
Copy Markdown
Member Author

OlegHahm commented Dec 19, 2013

Breaks?

@LudwigKnuepfer
Copy link
Copy Markdown
Member

LudwigKnuepfer commented Dec 19, 2013 

In file included from /home/lo/native/projects/default/../../RIOT/core/include/kernel.h:26:0,
                 from /home/lo/native/projects/default/../../RIOT/core/include/thread.h:26,
                 from main.c:13:
/home/lo/native/projects/default/../../RIOT/cpu/msp430-common/include/cpu.h:30:19: fatal error: board.h: No such file or directory

@LudwigKnuepfer
Copy link
Copy Markdown
Member

LudwigKnuepfer commented Dec 19, 2013

same with master though

@LudwigKnuepfer
Copy link
Copy Markdown
Member

LudwigKnuepfer commented Dec 19, 2013

Huh, I thought this was fixed with #408 ...

@OlegHahm
Copy link
Copy Markdown
Member Author

OlegHahm commented Dec 19, 2013

The underlying problem is #91 but this commit will fix it for now.

@LudwigKnuepfer
Copy link
Copy Markdown
Member

LudwigKnuepfer commented Dec 19, 2013

ACK

OlegHahm added a commit that referenced this pull request Dec 19, 2013
@OlegHahm
Merge pull request #437 from OlegHahm/include_directives
cdb77c2 
making include directives consistent
@OlegHahm OlegHahm merged commit cdb77c2 into RIOT-OS:master Dec 19, 2013
@OlegHahm OlegHahm deleted the include_directives branch December 19, 2013 16:38
@LudwigKnuepfer LudwigKnuepfer mentioned this pull request Dec 19, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BytesGalore BytesGalore

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistencies for include directives

3 participants

@OlegHahm @LudwigKnuepfer @BytesGalore