Skip to content

LPS25H pressure sensor driver#4257

Closed
ReneHerthel wants to merge 8 commits intoRIOT-OS:masterfrom
ReneHerthel:lps25h
Closed

LPS25H pressure sensor driver#4257
ReneHerthel wants to merge 8 commits intoRIOT-OS:masterfrom
ReneHerthel:lps25h

Conversation

@ReneHerthel
Copy link
Copy Markdown
Contributor

  • Reference for LPS25H.
  • Basic driver functionality
    • Initialize device
    • Read pressure output
    • Read temperature output
    • Enable / Disable device
  • Original issue of limifrog-v1 port

@OlegHahm OlegHahm added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: drivers Area: Device drivers labels Nov 11, 2015
@OlegHahm
Copy link
Copy Markdown
Member

Apparently your git client isn't configured using one of your Github mail addresses.

@OlegHahm OlegHahm modified the milestone: Release 2016.03 Dec 7, 2015
@ReneHerthel
Copy link
Copy Markdown
Contributor Author

Rebase

@OlegHahm
Copy link
Copy Markdown
Member

@ReneHerthel, @PeterKietzmann, what's the state?

@PeterKietzmann
Copy link
Copy Markdown
Member

@katezilla please review and test this one as well

@katezilla
Copy link
Copy Markdown
Contributor

@ReneHerthel can you rebase please

@PeterKietzmann
Copy link
Copy Markdown
Member

@katezilla please don't comment in separate commits

@katezilla
Copy link
Copy Markdown
Contributor

oh, sorry. was shown to me as one.

@ReneHerthel ReneHerthel force-pushed the lps25h branch 2 times, most recently from cb535ca to a82ae73 Compare February 29, 2016 11:51
@ReneHerthel
Copy link
Copy Markdown
Contributor Author

rebased

* @param[out] dev device descriptor of the sensor
* @param[in] i2c I2C bus the sensor is connected to
* @param[in] address the sensor's address on the I2C bus
* @param[in] rate internal sampling rate of the sensor
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/rate/odr

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [x]

@ReneHerthel
Copy link
Copy Markdown
Contributor Author

rebase

@OlegHahm
Copy link
Copy Markdown
Member

What the status here? Any chance to get this merged until next Wednesday?

@katezilla
Copy link
Copy Markdown
Contributor

tested changes. Now it doesn't crash anymore... but values are not right.
temperature shows 42°C and pressure value is alway 0, no matter what i try.

@OlegHahm realively low, as the values are completly wrong.

@OlegHahm
Copy link
Copy Markdown
Member

Thanks.

@PeterKietzmann PeterKietzmann modified the milestones: Release 2016.07, Release 2016.04 Mar 24, 2016
@kYc0o
Copy link
Copy Markdown
Contributor

kYc0o commented Jul 25, 2016

Feature freeze -> postponed.

@kYc0o kYc0o modified the milestones: Release 2016.10, Release 2016.07 Jul 25, 2016
@ReneHerthel
Copy link
Copy Markdown
Contributor Author

Rebase.

@ReneHerthel
Copy link
Copy Markdown
Contributor Author

ReneHerthel commented Oct 19, 2016

Hi @PeterKietzmann and @katezilla,

I've done here some fixes too. Now I'm waiting for Murdock to lock if there are some building errors. But this PR seems to be blocked? I'm not sure how to start it.

@PeterKietzmann
Copy link
Copy Markdown
Member

@ReneHerthel I assume you will have the same problem here as in #3263 but I will add the CI label anyway so you can have a look at the build output.

@PeterKietzmann PeterKietzmann added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 19, 2016
@PeterKietzmann
Copy link
Copy Markdown
Member

An one other thing: Did you encounter the same problems that Katja described and did you fix them???

@ReneHerthel
Copy link
Copy Markdown
Contributor Author

ReneHerthel commented Oct 20, 2016

@PeterKietzmann I fixed all things she said except the one thing, where she said "trying to figure out why the temperature value keeps counting up".
The sensors temperature output in the console behaves like a counter in two directions - increment and decrement.
Sometimes, it goes up to ~80C° and then it goes back to ~20°. But only, if I hold it in my hands.
I have to check if the sensor is that sensitive, or I just build unconsciously a counter in one of the functions.

And to Murdock:
At the first look it seems to be the same problem with the I2C driver.

@PeterKietzmann PeterKietzmann modified the milestones: Release 2017.01, Release 2016.10 Oct 20, 2016
@katezilla
Copy link
Copy Markdown
Contributor

@ReneHerthel i had that 'counter-like' bug in our office with normal temperatures. It counted also with an overflow but maybe it changed after your fixes.

@PeterKietzmann PeterKietzmann removed this from the Release 2017.01 milestone Jan 13, 2017
@aabadie aabadie added this to the Release 2017.04 milestone Apr 6, 2017
@aabadie aabadie added CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 6, 2017
@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Apr 6, 2017

ping @ReneHerthel, any update on this one ? it seems to be nearly ready.

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Jun 20, 2017

ping !

@aabadie
Copy link
Copy Markdown
Contributor

aabadie commented Jun 28, 2017

Closing in favor of #7267. Hope this is fine.

@aabadie aabadie closed this Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: drivers Area: Device drivers CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants