Skip to content

cpu/stm32f4: optimized UART driver#4115

Merged
thomaseichinger merged 7 commits intoRIOT-OS:masterfrom
haukepetersen:opt_stm32f4_uart
Dec 8, 2015
Merged

cpu/stm32f4: optimized UART driver#4115
thomaseichinger merged 7 commits intoRIOT-OS:masterfrom
haukepetersen:opt_stm32f4_uart

Conversation

@haukepetersen
Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen commented Oct 20, 2015

based on #4114

This driver is now utilizing DMA for transmitting data. This is possible through the changes in the UART driver interface and should save quite some energy as the CPU will now be able to sleep while sending data...

@haukepetersen haukepetersen added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Oct 20, 2015
@haukepetersen haukepetersen added this to the Release NEXT MAJOR milestone Oct 20, 2015
@haukepetersen haukepetersen mentioned this pull request Oct 20, 2015
Merged
35 tasks
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Oct 22, 2015

Either the commit set or the title of this PR seems to be off.

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Oct 22, 2015

nope, all fine

based on #4114

@jnohlgard
Copy link
Copy Markdown
Member

jnohlgard commented Oct 23, 2015

why the change to cpu/stm32f4/include/stm32f407xx.h ? Is that not the vendor-supplied hardware header?

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Oct 23, 2015

yes, it is - but it's shitty... I got used to actually editing those headers instead of introducing x lines of extra code in the drivers...

@jnohlgard
Copy link
Copy Markdown
Member

jnohlgard commented Oct 25, 2015

Could you split the stm32f407xx.h change to a separate commit? Makes it easier to get an overview in the future if we want to see what changes we have made to vendor headers.

@jnohlgard
Copy link
Copy Markdown
Member

jnohlgard commented Oct 25, 2015

btw, there's a new version of the header available with the Keil MDK (tagged @version V2.4.0, @date 14-August-2015), it has some various changes to the registers, you might want to update while you are messing around in this file.

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Oct 28, 2015

rebased and separated the vendor header changes in its own commit

@haukepetersen haukepetersen force-pushed the opt_stm32f4_uart branch 2 times, most recently from ffd1b8f to fe41568 Compare October 28, 2015 11:02
@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Oct 28, 2015

also adapted remaining stm32f4 based boards to the changes

@haukepetersen haukepetersen added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 28, 2015
@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Nov 24, 2015

fixed typo in RCC define for the msbiot and squashed it

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Nov 24, 2015

@gebart: are you good with this PR now?

@jnohlgard
Copy link
Copy Markdown
Member

jnohlgard commented Nov 24, 2015

I'm fine, did not test it though.

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Nov 24, 2015

fixed a small typing issue with cpp, Travis should be fine now.

thomaseichinger
thomaseichinger reviewed Dec 1, 2015
View reviewed changes
cpu/stm32f4/periph/uart.c Outdated
Copy link
Copy Markdown
Member

@thomaseichinger thomaseichinger Dec 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove if not needed.

Copy link
Copy Markdown
Contributor Author

@haukepetersen haukepetersen Dec 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups :-)

@thomaseichinger
Copy link
Copy Markdown
Member

thomaseichinger commented Dec 1, 2015

Could you please also adopt the nucleo-f401 board?

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Dec 1, 2015

done

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Dec 7, 2015

fixed minor comment by @thomaseichinger and squashed. @thomaseichinger: do you ack? There is a ready to use board in our office :-)

@thomaseichinger
Copy link
Copy Markdown
Member

thomaseichinger commented Dec 8, 2015

ACK & go

thomaseichinger added a commit that referenced this pull request Dec 8, 2015
@thomaseichinger
Merge pull request #4115 from haukepetersen/opt_stm32f4_uart
0f80e68 
cpu/stm32f4: optimized UART driver
@thomaseichinger thomaseichinger merged commit 0f80e68 into RIOT-OS:master Dec 8, 2015
@haukepetersen haukepetersen deleted the opt_stm32f4_uart branch December 8, 2015 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@thomaseichinger thomaseichinger

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2015.12

Development

Successfully merging this pull request may close these issues.

4 participants

@haukepetersen @OlegHahm @jnohlgard @thomaseichinger