core/panic: call cpu_print_last_instruction before printing other things#3930
Merged
OlegHahm merged 1 commit intoRIOT-OS:masterfrom Sep 22, 2015
Merged
Conversation
cgundogan
added
Type: bug
Member
|
Seems sensible. ACK |
OlegHahm
added
the
CI: ready for build
Member
|
(core...) Second ACK. |
Member
Author
|
partially kicked travis |
OlegHahm
added a commit
that referenced
this pull request
Sep 22, 2015
core/panic: call cpu_print_last_instruction before printing other things
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler (at least for the iotlab-m3) is clever enough to not change the link register for subsequent calls to puts/printf. This will however result in a false link register reported to the user/developer when an assert fails.
By moving
cpu_print_last_instruction()up and make it the first function to be called bypasses this.fixes #3920