Skip to content

gnrc_pktbuf_static: fix marking of pktsnips with short payload#3925

Merged
miri64 merged 2 commits intoRIOT-OS:masterfrom
miri64:gnrc_pktbuf_static/fix/short_snip
Sep 22, 2015
Merged

gnrc_pktbuf_static: fix marking of pktsnips with short payload#3925
miri64 merged 2 commits intoRIOT-OS:masterfrom
miri64:gnrc_pktbuf_static/fix/short_snip

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Sep 22, 2015

Fixes #3815 and provides a test for the situation in which the bug occurs: If a payload of a packet is smaller then the _unused_t marker of the packet buffer the marker overrides the following data when the packet is released. Due to that such packets needs to be moved on marking.

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking Impact: major The PR changes a significant part of the code base. It should be reviewed carefully labels Sep 22, 2015
@miri64 miri64 added this to the Release 2015.09 milestone Sep 22, 2015
@cgundogan
Copy link
Copy Markdown
Member

nice, I will test it at once!

@cgundogan
Copy link
Copy Markdown
Member

ACK. Could not enforce a hard fault with udp/ping whatsoever in multi-hop scenarios

@cgundogan cgundogan added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 22, 2015
miri64 added a commit that referenced this pull request Sep 22, 2015
…rt_snip

gnrc_pktbuf_static: fix marking of pktsnips with short payload
@miri64 miri64 merged commit 8df17de into RIOT-OS:master Sep 22, 2015
@miri64 miri64 deleted the gnrc_pktbuf_static/fix/short_snip branch September 22, 2015 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: major The PR changes a significant part of the code base. It should be reviewed carefully Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants