rpl: fix src addr of outgoing control messages#3913
Closed
cgundogan wants to merge 0 commit intoRIOT-OS:masterfrom
Closed
rpl: fix src addr of outgoing control messages#3913cgundogan wants to merge 0 commit intoRIOT-OS:masterfrom
cgundogan wants to merge 0 commit intoRIOT-OS:masterfrom
Conversation
cgundogan
added
Type: bug
Member
|
What's with the removal of the |
Member
Author
|
The |
Member
|
I'll leave the rest of the review to @OlegHahm.. |
Member
|
Independent from know-how the change looks however sensible and it seems to work on testbed (initialized 4 nodes with one root and was able to ping a non-root from a non-root). ACK |
miri64
added
the
CI: ready for build
cgundogan
force-pushed
the
pr/rpl/linklocal
branch
from
3a43a76 to
947817e
Compare
cgundogan
force-pushed
the
pr/rpl/linklocal
branch
from
947817e to
1f02e7c
Compare
Member
|
? |
Member
|
He's got some problems changing some stuff. |
Member
Author
|
trying to push my stuff, but github times out right now .. loading.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, RPL assumes a link local address that was derived from the global address. This is not true anymore (and was also a bad solution anyway).
Now I just ask for any link local address as the src address of control messages with
gnrc_ipv6_netif_match_prefix(). (@authmillenon any remarks?)Without this, routing is broken.