samd21: tidy up peripheral clocks and fix potential bugs#3887
Merged
daniel-k merged 1 commit intoRIOT-OS:masterfrom Sep 30, 2015
Merged
samd21: tidy up peripheral clocks and fix potential bugs#3887daniel-k merged 1 commit intoRIOT-OS:masterfrom
daniel-k merged 1 commit intoRIOT-OS:masterfrom
Conversation
daniel-k
added
Type: bug
thomaseichinger
added
the
CI: ready for build
Member
|
@daniel-k Looks good, please squash. |
daniel-k
force-pushed
the
pr/samd21_clocks
branch
from
d9e0318 to
0b6da46
Compare
daniel-k
removed
the
CI: needs squashing
Member
Author
|
@thomaseichinger |
Member
|
ACK when Travis passed. |
Member
Author
|
Travis is green, let's go. |
daniel-k
added a commit
that referenced
this pull request
Sep 30, 2015
samd21: tidy up peripheral clocks and fix potential bugs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While revising some clock setups I stumbled upon 2 potential bugs and eliminated some implicit options (
GCLK_CLKCTRL_GEN_GCLK0evaluates to0but it's nice to see it if you don't know).Additionally I redirect all peripherals to a disabled clock generator at the end of the cpu clock initialization. That saves approx. 1mA while MCU is executing, depending on the enabled peripherals. See reference