Skip to content

posix: remove strcasecmp functions and macros#3864

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64:posix/api/rm-strings
Sep 17, 2015
Merged

posix: remove strcasecmp functions and macros#3864
miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64:posix/api/rm-strings

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Sep 16, 2015

Those functions and macros are already provided by glibc and newlib, but not by libc-msp430 and libc-avr. However, the only library that uses them is libcoap which is too fat for msp430 and avr boards. And since they prove this proved to be a little bit difficult in #3612, this PR removes them

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: POSIX Area: POSIX API wrapper Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. labels Sep 16, 2015
@miri64 miri64 added this to the Release 2015.09 milestone Sep 16, 2015
@miri64 miri64 mentioned this pull request Sep 16, 2015
Merged
@cgundogan
Copy link
Copy Markdown
Member

cgundogan commented Sep 16, 2015

ACK

@cgundogan cgundogan added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 16, 2015
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Sep 16, 2015

However, the only library that uses them is libcoap which is too fat for msp430 and avr boards.

Are we sure about this?

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 16, 2015

The test app that uses libcoap (and nothing much else) is blacklisting them.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 16, 2015

I would prefer to discuss how to handle those boards + POSIX for the next release. I've tried to sneak in some optimizations to the posix module during my rework of pnet to posix_sockets but if we want to finally solidify our POSIX support, we need to discuss what we want to support and how we deal with such conflicts (apart from different libcs supporting different stuff from the POSIX specification there is also the issue of missing definitions from the POSIX specification from in existing libc files), among other things.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 16, 2015

there is also the issue of missing definitions from the POSIX specification from in existing libc files

Most prominent example that comes to my mind is close() in newlib's unistd.h, which does not exist IIRC

@cgundogan
Copy link
Copy Markdown
Member

cgundogan commented Sep 16, 2015

ACK holds. Nothing seems to be broken so far. These string functions can be added for specific targets in a later phase

miri64 added a commit that referenced this pull request Sep 17, 2015
@miri64
Merge pull request #3864 from authmillenon/posix/api/rm-strings
f1046b4 
posix: remove strcasecmp functions and macros
@miri64 miri64 merged commit f1046b4 into RIOT-OS:master Sep 17, 2015
@miri64 miri64 deleted the posix/api/rm-strings branch September 17, 2015 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cgundogan cgundogan

Labels

Area: POSIX Area: POSIX API wrapper CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Milestone

Release 2015.09

Development

Successfully merging this pull request may close these issues.

3 participants

@miri64 @cgundogan @OlegHahm