cpu/stm32l1: optimized and fixed timer driver#3856
Merged
haukepetersen merged 4 commits intoRIOT-OS:masterfrom Sep 22, 2015
Merged
cpu/stm32l1: optimized and fixed timer driver#3856haukepetersen merged 4 commits intoRIOT-OS:masterfrom
haukepetersen merged 4 commits intoRIOT-OS:masterfrom
Conversation
haukepetersen
added
Type: enhancement
haukepetersen
added
the
CI: ready for build
Merged
Member
There was a problem hiding this comment.
A division for every time referencing a constant value?
Member
There was a problem hiding this comment.
The constant will be computed by the compiler at compile time, there won't
be a division at run time.
On Sep 15, 2015 8:18 PM, "A-Paul" [email protected] wrote:
In boards/nucleo-l1/include/periph_conf.h
#3856 (comment):-#define TIMER_1_MAX_VALUE (0xffff)
-#define TIMER_1_CLKEN() (RCC->APB1ENR |= (RCC_APB1ENR_TIM4EN | RCC_APB1ENR_TIM5EN))
-#define TIMER_1_ISR_0 isr_tim4
-#define TIMER_1_ISR_1 isr_tim5
-#define TIMER_1_IRQ_CHAN_0 TIM4_IRQn
-#define TIMER_1_IRQ_CHAN_1 TIM5_IRQn
-#define TIMER_1_IRQ_PRIO 1
-#define TIMER_1_TRIG_SEL TIM_SMCR_TS_1
+static const timer_conf_t timer_config[] = {
- /* device, RCC bit, IRQ bit */
- {TIM5, 3, TIM5_IRQn},
+};
+/* interrupt routines /
+#define TIMER_0_ISR (isr_tim5)
+/ number of defined timers */
+#define TIMER_NUMOF (sizeof(timer_config) / sizeof(timer_config[0]))A division for every time referencing a constant value?
—
Reply to this email directly or view it on GitHub
https://github.com/RIOT-OS/RIOT/pull/3856/files#r39546009.
Contributor
Author
|
adjusted configuration for the |
haukepetersen
force-pushed
the
opt_l1_timer
branch
from
94591e0 to
e0f1c6c
Compare
Member
|
@ReneHerthel took it home. So he has to. I'll also send him a private mail |
Contributor
Author
|
thx |
Contributor
|
Okey, I cloned this branch and tested it with the xtimer-test applications from RIOT. |
Member
I think this is okay, because this test is only for platforms with timers smaller than 32 bit. |
Member
|
Needs rebase |
haukepetersen
force-pushed
the
opt_l1_timer
branch
from
e0f1c6c to
7f46297
Compare
Contributor
Author
|
rebased |
Contributor
Author
|
@OlegHahm, care to give this a fix test-run? |
Member
|
Ah, now I remember. I cannot test, because I don't any output on this board. |
Contributor
Author
|
If I tell you it's working fine here, does that suffice? |
Contributor
Author
|
Or you can come over and I give you a live demo (as live demos always work...) :-) |
Member
|
Okay, got it working with the second UART, but No further output. |
Member
|
Wait, it's weird. Somehow flashing doesn't seem to work. |
Member
|
Ok, fixed that, but got the same result for xtimer_set_msg as above. |
Contributor
Author
|
hmm, here it does not stop, though I get the same faulty output... |
haukepetersen
force-pushed
the
opt_l1_timer
branch
from
7f46297 to
92ee5d9
Compare
Contributor
Author
|
should be fixed now. |
Contributor
Author
|
@OlegHahm: now |
Member
|
ACK |
Contributor
Author
|
Travis is happy -> and go. |
haukepetersen
added a commit
that referenced
this pull request
Sep 22, 2015
cpu/stm32l1: optimized and fixed timer driver
Contributor
There was a problem hiding this comment.
First argument should be "1" here, shouldn't it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
saves ~600 byte ROM and looks nicer :-)
also #3525 works nicely with this.