Skip to content

ipv6_addr: make IPv4 compatible addresses optional#3822

Merged
OlegHahm merged 2 commits intoRIOT-OS:masterfrom
miri64:ipv6_addr/enh/opt-ipv4-sup
Sep 15, 2015
Merged

ipv6_addr: make IPv4 compatible addresses optional#3822
OlegHahm merged 2 commits intoRIOT-OS:masterfrom
miri64:ipv6_addr/enh/opt-ipv4-sup

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Sep 11, 2015

Asked by @haukepetersen and @cgundogan (and others) in #3608, now delivered

Depends on #3608.

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking labels Sep 11, 2015
@miri64 miri64 added this to the Release 2015.09 milestone Sep 11, 2015
@miri64 miri64 mentioned this pull request Sep 11, 2015
Merged
@miri64 miri64 added the State: waiting for other PR State: The PR requires another PR to be merged first label Sep 11, 2015
@cgundogan cgundogan removed the State: waiting for other PR State: The PR requires another PR to be merged first label Sep 11, 2015
@cgundogan
Copy link
Copy Markdown
Member

cgundogan commented Sep 11, 2015

rebase to current master please

@miri64 miri64 force-pushed the ipv6_addr/enh/opt-ipv4-sup branch from ae2da67 to f595ac3 Compare September 11, 2015 18:03
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 11, 2015

Rebased to current master

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 11, 2015

Test with

make -C tests/unittests tests-ipv6_addr test
USEMODULE=ipv4_addr make -C tests/unittests clean tests-ipv6_addr test

cgundogan
cgundogan reviewed Sep 15, 2015
View reviewed changes
sys/include/net/ipv6/addr.h
Copy link
Copy Markdown
Member

@cgundogan cgundogan Sep 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the second @brief section is not necessary IMO

Copy link
Copy Markdown
Member Author

@miri64 miri64 Sep 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did not even give me time to fix this :(

@cgundogan
Copy link
Copy Markdown
Member

cgundogan commented Sep 15, 2015

I tested with the existing unittest and with gnrc_example. Building without ipv4_addr cuts 400 bytes of ROM for the samr21-xpro in the gnrc_example 👍

ACK

@cgundogan cgundogan added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 15, 2015
OlegHahm added a commit that referenced this pull request Sep 15, 2015
@OlegHahm
Merge pull request #3822 from authmillenon/ipv6_addr/enh/opt-ipv4-sup
f8f7446 
ipv6_addr: make IPv4 compatible addresses optional
@OlegHahm OlegHahm merged commit f8f7446 into RIOT-OS:master Sep 15, 2015
@miri64 miri64 deleted the ipv6_addr/enh/opt-ipv4-sup branch September 15, 2015 09:15
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 15, 2015

I tested with the existing unittest and with gnrc_example. Building without ipv4_addr cuts 400 bytes of ROM for the samr21-xpro in the gnrc_example 👍

Building with ENABLE_DEBUG should also be a little smaller now, since the addr_str buffers are a little shorter without ipv4_addr now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cgundogan cgundogan

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2015.09

Development

Successfully merging this pull request may close these issues.

3 participants

@miri64 @cgundogan @OlegHahm