Skip to content

boards: removed support for redbee-econotag#3766

Merged
kaspar030 merged 5 commits intoRIOT-OS:masterfrom
haukepetersen:rm_econotag
Sep 4, 2015
Merged

boards: removed support for redbee-econotag#3766
kaspar030 merged 5 commits intoRIOT-OS:masterfrom
haukepetersen:rm_econotag

Conversation

@haukepetersen
Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen commented Sep 3, 2015

I propose to remove the redbee-econotag port for several reasons:

  • its not maintained well -> at least for me locally here it's not even building
  • to my information it is not used by anyone (correct me if I am wrong!)
  • the CPU would need a lot of attention to make it confirm to peripheral drivers and related changes (e.g. sys: remove uart0 #3164), effectively slowing us down quite a bit
  • the platform has a serious RAM problem, since all code needs to be transferred into RAM so it can be executed -> this means that all our networking code does not run on this platform anyway

If there are good reasons for keeping this platform and anyone is volunteering for keeping it up to date I am happy to close this PR again, otherwise I would vote for dropping the support for now and re-add it if there is the need for it later.

@haukepetersen haukepetersen added Platform: ARM Platform: This PR/issue effects ARM-based platforms Impact: major The PR changes a significant part of the code base. It should be reviewed carefully Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Sep 3, 2015
@haukepetersen haukepetersen added this to the Release 2015.09 milestone Sep 3, 2015
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Sep 3, 2015

its not maintained well -> at least for me locally here it's not even building

Also, I'm completely fine to remove this legacy board, this sounds weird. What's the error?

@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Sep 3, 2015

I completely agree. ACK. Let's wait for a second one.

@OlegHahm OlegHahm added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 3, 2015
@kaspar030 kaspar030 mentioned this pull request Sep 3, 2015
Merged
10 tasks
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Sep 3, 2015

Second ACK, but I would still leave this open for at least 24 hours, to give a potential user/supporter of this platform the chance to object.

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Sep 3, 2015

fine with me

@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Sep 3, 2015

Unfortunately that blocks uart0 removal...

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Sep 3, 2015

Well, I guess we can live with this delay. Since we're in feature freeze, nothing should cause rebasing.

@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Sep 3, 2015 via email

@thomaseichinger
Copy link
Copy Markdown
Member

thomaseichinger commented Sep 3, 2015

There are several occurrences of redbee-econotag in Makefiles. Namely

  • examples/gnrc_networking/Makefile
  • tests/coap/Makefile
  • tests/posix_semaphore/Makefile
  • tests/struct_tm_utility/Makefile
  • tests/thread_cooperation/Makefile
  • tests/unittests/Makefile

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Sep 4, 2015

removed blacklistings

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Sep 4, 2015

Travis is happy, any last regrets? Otherwise feel free to push the button :-)

kaspar030 added a commit that referenced this pull request Sep 4, 2015
@kaspar030
Merge pull request #3766 from haukepetersen/rm_econotag
128d9db 
boards: removed support for redbee-econotag
@kaspar030 kaspar030 merged commit 128d9db into RIOT-OS:master Sep 4, 2015
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Sep 4, 2015

3 hours early, but I guess it's okay. ;)

@haukepetersen haukepetersen deleted the rm_econotag branch September 4, 2015 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@thomaseichinger thomaseichinger

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: major The PR changes a significant part of the code base. It should be reviewed carefully Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2015.09

Development

Successfully merging this pull request may close these issues.

4 participants

@haukepetersen @OlegHahm @kaspar030 @thomaseichinger