Skip to content

shell_commands: provide command for 6Lo context administration at 6LBR#3750

Merged
miri64 merged 2 commits intoRIOT-OS:masterfrom
miri64:shell/feat/6ctx
Sep 24, 2015
Merged

shell_commands: provide command for 6Lo context administration at 6LBR#3750
miri64 merged 2 commits intoRIOT-OS:masterfrom
miri64:shell/feat/6ctx

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Aug 31, 2015

Provides a shell command to administrate 6LoWPAN compression contexts at the border router.

Depends on #3134 (merged) (and #3525 to work properly).

@miri64 miri64 added Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT NSTF labels Aug 31, 2015
@miri64 miri64 added this to the Release 2015.08 milestone Aug 31, 2015
@OlegHahm OlegHahm added the State: waiting for other PR State: The PR requires another PR to be merged first label Aug 31, 2015
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Aug 31, 2015

Rebased to current #3134

@miri64 miri64 force-pushed the shell/feat/6ctx branch 2 times, most recently from ce5160c to ad7e203 Compare September 2, 2015 22:38
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 2, 2015

Rebased to current #3134.

@miri64 miri64 force-pushed the shell/feat/6ctx branch 2 times, most recently from 659faea to 58cb27f Compare September 3, 2015 08:33
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 3, 2015

Rebased to current #3134

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 9, 2015

Rebased to current #3134

1 similar comment
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 10, 2015

Rebased to current #3134

@miri64 miri64 force-pushed the shell/feat/6ctx branch 2 times, most recently from 6eae09e to 2e96ec1 Compare September 11, 2015 17:59
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 11, 2015

Rebased to current master

@OlegHahm
Copy link
Copy Markdown
Member

What do I have to do to get this building with gnrc_networking example? Just replacing gnrc_ipv6_router_default by gnrc_sixlowpan_nd_border_router or adding it doesn't seem to work.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 12, 2015

gnrc_ipv6_border_router_default

@OlegHahm
Copy link
Copy Markdown
Member

make sense ;)

@OlegHahm
Copy link
Copy Markdown
Member

For the record: the (pseudo) module is called gnrc_sixlowpan_border_router_default.

A dependency to xtimer is missing.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can shorten this to something like: "'del' will only invalidate the context for compression which can be reassigned after 5 min."

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 14, 2015

A dependency to xtimer is missing.

Should I add it as a dependency for shell_commands? That seems weird to me... Because the xtimer is only used by the shell command, not the border router itself (yet).

@OlegHahm
Copy link
Copy Markdown
Member

Hm, maybe we just wait for switch to xtimer then...

@kaspar030
Copy link
Copy Markdown
Contributor

+1

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 14, 2015

As stated in the description ;-)

@OlegHahm OlegHahm removed the State: waiting for other PR State: The PR requires another PR to be merged first label Sep 16, 2015
@OlegHahm
Copy link
Copy Markdown
Member

I guess a rebase is required.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 16, 2015

Rebased

@OlegHahm OlegHahm added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 17, 2015
@OlegHahm
Copy link
Copy Markdown
Member

please squash

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 17, 2015

Squashed

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 17, 2015

(but not pushed >.<)

@OlegHahm
Copy link
Copy Markdown
Member

How can I test and how and when should the configured context get propagated?

@OlegHahm
Copy link
Copy Markdown
Member

After configuring a context for my prefix, pinging to or via the 6LBR doesn't work any more.

@OlegHahm
Copy link
Copy Markdown
Member

However, that's probably not related to the shell commands themselves.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 21, 2015

Rebased to current master.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 22, 2015

Added immediate advertisement for contexts (and fixed a bug that was revealed by that in net/gnrc/ndp/internal.h)

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 22, 2015

Fix for #3750 (comment) will follow. I think I know what's happening.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 22, 2015

Fix for #3750 (comment) will follow. I think I know what's happening.

it's #3928 if that wasn't clear.

@OlegHahm
Copy link
Copy Markdown
Member

ACK

@OlegHahm OlegHahm added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Sep 23, 2015
@OlegHahm
Copy link
Copy Markdown
Member

Please squash and merge as soon as Travis is green. With #3949 this is working. (However, this PR iteelf is sane anyway.)

@miri64 miri64 removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Sep 23, 2015
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 23, 2015

Squashed and rebased.

miri64 added a commit that referenced this pull request Sep 24, 2015
shell_commands: provide command for 6Lo context administration at 6LBR
@miri64 miri64 merged commit dd7b96c into RIOT-OS:master Sep 24, 2015
@miri64 miri64 deleted the shell/feat/6ctx branch September 24, 2015 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants