Skip to content

cpu/msp430: added periph UART driver#3742

Merged
haukepetersen merged 9 commits intoRIOT-OS:masterfrom
haukepetersen:add_msp430_periph_uart
Sep 3, 2015
Merged

cpu/msp430: added periph UART driver#3742
haukepetersen merged 9 commits intoRIOT-OS:masterfrom
haukepetersen:add_msp430_periph_uart

Conversation

@haukepetersen
Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen commented Aug 28, 2015

EDIT
depends on #3724

Finally also the UART driver for the MSP430 based boards.

While serial output (hello-world) is working fine, the shell is still having trouble. I am still debugging some unwanted crashing when returning from the UART RX interrupt. But since I am now to MSP430 devices, I PR this anyway, maybe someone experiences with this platform has an idea?

By the way: the default example does not work out of the box, as it is trying to use uart0, while I basically removed uart0 support for these boards...

@haukepetersen haukepetersen added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Platform: MSP Platform: This PR/issue effects MSP-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Aug 28, 2015
@haukepetersen haukepetersen added this to the Release 2015.08 milestone Aug 28, 2015
@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Aug 28, 2015

we're getting there! ;)

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Aug 29, 2015

Please remind me to test this on Monday.

@PeterKietzmann
Copy link
Copy Markdown
Member

PeterKietzmann commented Aug 31, 2015

@OlegHahm, please test this today. It is monday :-)

@PeterKietzmann PeterKietzmann mentioned this pull request Aug 31, 2015
Merged
10 tasks
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Sep 1, 2015

It's not Monday any more, but I just realized that I don't have any MSP430 flashing tools any more. Can't test until someone returns hers or his to me.

@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Sep 2, 2015

I'm on this now. TX seems fine, but I can reproduce crashes on RX.

@OlegHahm OlegHahm assigned kaspar030 and unassigned OlegHahm Sep 2, 2015
@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Sep 2, 2015

@kaspar030: Regarding the RX crashes, I just found similar behavior debugging the GPIO external interrupts. It seems to me, like there is something in the context switching that is broken for MSP430 platforms (but not sure yet...).

This was referenced Sep 2, 2015
Merged
Merged
thomaseichinger
thomaseichinger reviewed Sep 2, 2015
View reviewed changes
cpu/msp430fxyz/periph/uart.c Outdated
Copy link
Copy Markdown
Member

@thomaseichinger thomaseichinger Sep 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resets the reset bit which is holt while existing configuration.

Copy link
Copy Markdown
Contributor Author

@haukepetersen haukepetersen Sep 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups :-)

@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Sep 2, 2015

rebased on changes in #3724 and fixed the interrupt problem. The default example (without uart0) does run smoothely now on the msb-430(h) boards.

@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Sep 2, 2015

@haukepetersen Nice, so this one is the only one standing between remove_uart0 and simplify_shell.

@kaspar030
Copy link
Copy Markdown
Contributor

kaspar030 commented Sep 3, 2015

I can confirm that periph/uart works on msb-430h.

@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 3, 2015
@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Sep 3, 2015

fixed interrupt vector names for the wsn430 boards

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Sep 3, 2015

Confirmed working on wsn430-v1_3b, wsn430-v1_4, and Zolertia Z1.

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Sep 3, 2015

ACK

@OlegHahm OlegHahm added the State: waiting for other PR State: The PR requires another PR to be merged first label Sep 3, 2015
@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Sep 3, 2015

rebased as #3724 was merged. Lets wait for Travis...

@OlegHahm OlegHahm removed the State: waiting for other PR State: The PR requires another PR to be merged first label Sep 3, 2015
@haukepetersen
Copy link
Copy Markdown
Contributor Author

haukepetersen commented Sep 3, 2015

oh happy day -> and go.

haukepetersen added a commit that referenced this pull request Sep 3, 2015
@haukepetersen
Merge pull request #3742 from haukepetersen/add_msp430_periph_uart
eb49be3 
cpu/msp430: added periph UART driver
@haukepetersen haukepetersen merged commit eb49be3 into RIOT-OS:master Sep 3, 2015
@haukepetersen haukepetersen deleted the add_msp430_periph_uart branch September 3, 2015 11:30
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Sep 3, 2015

cd pub && more beer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kaspar030 kaspar030

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: MSP Platform: This PR/issue effects MSP-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2015.09

Development

Successfully merging this pull request may close these issues.

5 participants

@haukepetersen @kaspar030 @OlegHahm @PeterKietzmann @thomaseichinger