Skip to content

shell: uart0 newlib distinction (workaround)#3690

Merged
cgundogan merged 2 commits intoRIOT-OS:masterfrom
OlegHahm:shell_uart0_newlib_distinction
Aug 25, 2015
Merged

shell: uart0 newlib distinction (workaround)#3690
cgundogan merged 2 commits intoRIOT-OS:masterfrom
OlegHahm:shell_uart0_newlib_distinction

Conversation

@OlegHahm
Copy link
Copy Markdown
Member

Replaces #3555 to fix #3550 for now.

I agree that #3164 and #3402 are the much cleaner solution, but since it will still take a while to get them merged and working with Cortex platforms is currently annoying, I would vote for merging this ASAP. The changes can be easily reverted once #3402 is ready.

@OlegHahm OlegHahm added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties labels Aug 22, 2015
@cgundogan
Copy link
Copy Markdown
Member

ACK. tried to break the shell on the iotlab testbed. I was not able to.

@haukepetersen haukepetersen added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 25, 2015
@haukepetersen
Copy link
Copy Markdown
Contributor

ACK once Travis...

@OlegHahm OlegHahm force-pushed the shell_uart0_newlib_distinction branch from d81fbc8 to 9c6ab10 Compare August 25, 2015 18:14
@OlegHahm
Copy link
Copy Markdown
Member Author

Copy & paste error in one test application. Fixed and squashed immediately.

@cgundogan
Copy link
Copy Markdown
Member

travis approves

cgundogan added a commit that referenced this pull request Aug 25, 2015
shell: uart0 newlib distinction (workaround)
@cgundogan cgundogan merged commit ed3a339 into RIOT-OS:master Aug 25, 2015
@OlegHahm OlegHahm deleted the shell_uart0_newlib_distinction branch August 25, 2015 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shell: broken on Cortex-M platforms

4 participants