Skip to content

posix: redo socket API to use conn#3646

Merged
miri64 merged 3 commits intoRIOT-OS:masterfrom
miri64:posix/feat/sockets
Sep 22, 2015
Merged

posix: redo socket API to use conn#3646
miri64 merged 3 commits intoRIOT-OS:masterfrom
miri64:posix/feat/sockets

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Aug 18, 2015

Depends on #3611 (merged), #3612 (merged), #3615 (merged) and #3660 (merged).

@miri64 miri64 added Area: POSIX Area: POSIX API wrapper Area: network Area: Networking State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet missing feature labels Aug 18, 2015
@miri64 miri64 added this to the Release 2015.08 milestone Aug 18, 2015
@BytesGalore
Copy link
Copy Markdown
Member

BytesGalore commented Aug 18, 2015

oh that's not really what I want, sry. (see #3646 (comment))

miri64
miri64 reviewed Aug 18, 2015
View reviewed changes
sys/posix/sockets/posix_sockets.c Outdated
Copy link
Copy Markdown
Member Author

@miri64 miri64 Aug 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From miri64@902d305#commitcomment-12756195:

how about:

case AF_INET:
case AF_INET6:
    s->domain = domain;
    s->type = type;
    if ((s->protocol = _choose_ipproto(type, protocol)) < 0) {
        res = -1;
    }
    break;

That's different from the current code in that this code segment will be entered even if the associated connection modules are not there. But I can put the EAFNOSUPPORT check for them to the top.

Copy link
Copy Markdown
Member

@BytesGalore BytesGalore Aug 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh domain may be AF_INET or AF_INET6 even if CONN_IPV4 || CONN_IPV6 are not available, the forget my noise :)

@miri64 miri64 force-pushed the posix/feat/sockets branch 3 times, most recently from 60518b4 to fb6c95f Compare August 19, 2015 02:49
@miri64 miri64 force-pushed the posix/feat/sockets branch from fb6c95f to 82fd442 Compare August 26, 2015 12:02
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Aug 26, 2015

Rebased to current master

@OlegHahm OlegHahm added the State: waiting for other PR State: The PR requires another PR to be merged first label Aug 26, 2015
@miri64 miri64 mentioned this pull request Aug 31, 2015
Closed
36 tasks
@miri64 miri64 force-pushed the posix/feat/sockets branch from 82fd442 to 5f15c4d Compare September 7, 2015 14:58
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 7, 2015

Rebased to current master and dependencies.

@miri64 miri64 mentioned this pull request Sep 7, 2015
Merged
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 11, 2015

oh that's not really what I want, sry.

@BytesGalore what did you mean with that?

@miri64 miri64 force-pushed the posix/feat/sockets branch 2 times, most recently from a6d9313 to 06185b5 Compare September 11, 2015 18:24
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 11, 2015

Rebased to current dependencies

@miri64 miri64 removed the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Sep 11, 2015
@BytesGalore
Copy link
Copy Markdown
Member

BytesGalore commented Sep 14, 2015

@BytesGalore what did you mean with that?

nvm. @OlegHahm pointed me that I commented on commits from this PR and not on the PR, so that was something I didn't wanted :)

@miri64 miri64 force-pushed the posix/feat/sockets branch 2 times, most recently from bfec82b to e83244b Compare September 15, 2015 10:06
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 15, 2015

Rebased to current master and dependencies.

@miri64 miri64 force-pushed the posix/feat/sockets branch 2 times, most recently from bfec82b to 647a0af Compare September 15, 2015 10:13
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 15, 2015

And now for real.

@emmanuelsearch
Copy link
Copy Markdown
Member

emmanuelsearch commented Sep 22, 2015

Maybe the READ ME could be more complete -- especially for programmers expected above a POSIX socket in this context. E.g. in EXAMPLE OUTPUT, indicate that ifconfig gives you the IP address, and say that the UDP port number used here is not to be confused with the port used for the shell indicated in USAGE. In USAGE, indicate that on native, no need to indicate a port.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 22, 2015

In USAGE, indicate that on native, no need to indicate a port.

Since when? If you want to use a different tap interface apart from tap0 you need to inticate a port.

@emmanuelsearch
Copy link
Copy Markdown
Member

emmanuelsearch commented Sep 22, 2015

In USAGE, indicate that on native, no need to indicate a port.

oops my bad. Ignore ;)

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 22, 2015

Update README.

@emmanuelsearch
Copy link
Copy Markdown
Member

emmanuelsearch commented Sep 22, 2015

Looks good. ACK.

@OlegHahm OlegHahm added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 22, 2015
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 22, 2015

Squashed

@miri64 miri64 removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Sep 22, 2015
@miri64 miri64 force-pushed the posix/feat/sockets branch 2 times, most recently from f88e409 to ded545d Compare September 22, 2015 18:41
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 22, 2015

Fixed issues with coap app and added low-memory boards to BOARD_INSUFFICIENT_MEMORY.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 22, 2015

Another (bug) one bites the dust. This time it was Arduino with its pesky 16-bit ints again

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 22, 2015

(hopefully) last one. tests/coap is due to gnrc too big for stm32f0discovery.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 22, 2015

Let's give it one last round for today, shall we (blacklisted msp430 and avr boards for tests/coap again, since they have problems with libcoaps :x notation in structs and added include to kernel_types.h to sys/posix.h to have ssize_t on msp430)

miri64 added a commit that referenced this pull request Sep 22, 2015
@miri64
Merge pull request #3646 from authmillenon/posix/feat/sockets
4508e22 
posix: redo socket API to use conn
@miri64 miri64 merged commit 4508e22 into RIOT-OS:master Sep 22, 2015
@miri64 miri64 deleted the posix/feat/sockets branch September 22, 2015 21:04
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Sep 22, 2015

The last comment sounded like a question...

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 22, 2015

It was a rhetorical question intended to mask my frustration about the last minutes of this PR.

@miri64 miri64 added the Type: new feature The issue requests / The PR implemements a new feature for RIOT label Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BytesGalore BytesGalore

Labels

Area: network Area: Networking Area: POSIX Area: POSIX API wrapper CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2015.09

Development

Successfully merging this pull request may close these issues.

5 participants

@miri64 @BytesGalore @emmanuelsearch @OlegHahm @LudwigKnuepfer