drivers: periph: add generic spi fallbacks#3620
Merged
kaspar030 merged 9 commits intoRIOT-OS:masterfrom Aug 14, 2015
Merged
Conversation
kaspar030
added
the
Type: cleanup
kaspar030
added
the
Discussion: RFC
kaspar030
added
the
CI: ready for build
Contributor
Author
|
(launching CI to spot build errors) |
kaspar030
force-pushed
the
add_generic_spi_fallbacks
branch
from
ccbc85e to
81edd16
Compare
Contributor
Author
|
Contributor
|
I actually had something similar in mind once, but never got to it. In #3216 I actually already improved those implementations a bit, though the PR slipped pretty far down on my prio list... ACK once squashed and Travis is happy. |
This module contains shared functions for periph implementations.
kaspar030
force-pushed
the
add_generic_spi_fallbacks
branch
from
75cb58a to
6b2b5eb
Compare
Contributor
Author
|
and GO. |
kaspar030
added a commit
that referenced
this pull request
Aug 14, 2015
drivers: periph: add generic spi fallbacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've seen multiple definitions of basically the same functions, so I factored them out into a common module.
There's room for more, e.g., the locking of SPI buses could be unified in the same way.
For spi_transfer_reg*, I've chosen the implementation with the most eror checking, though I'm not sure that is actually needed or even harmful.